Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 12218007: Implement substitution for type variables. (Closed)

Created:
7 years, 10 months ago by karlklose
Modified:
7 years, 9 months ago
Reviewers:
ngeoffray, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Implement substitution for type variables. Committed: https://code.google.com/p/dart/source/detail?r=18376

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+381 lines, -146 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart View 9 chunks +91 lines, -25 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/namer.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart View 5 chunks +154 lines, -30 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/foreign_helper.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_helper.dart View 6 chunks +62 lines, -17 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 6 chunks +48 lines, -50 lines 1 comment Download
M sdk/lib/_internal/compiler/implementation/ssa/codegen.dart View 1 chunk +0 lines, -11 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/nodes.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +4 lines, -6 lines 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/html/html.status View 1 chunk +5 lines, -0 lines 1 comment Download
M tests/language/language_dart2js.status View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
The main part of this patch has been reviewed as https://codereview.chromium.org/12018015/.
7 years, 10 months ago (2013-02-08 09:31:38 UTC) #1
karlklose
Nicolas, PTAL at the builder/codegen change wrt. https://codereview.chromium.org/12210013/ This is not ready for committing, as ...
7 years, 10 months ago (2013-02-08 14:51:46 UTC) #2
blois
7 years, 9 months ago (2013-03-02 01:43:53 UTC) #3
Message was sent while issue was closed.
https://codereview.chromium.org/12218007/diff/11005/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/12218007/diff/11005/tests/html/html.status#ne...
tests/html/html.status:331: element_test/queryAll: Fail # missing substitution
on native classes
These failures are extremely disturbing- this is core functionality which is now
untested.

I do not think this CL should have been submitted if it breaks these tests-
these are testing very basic functionality.

Powered by Google App Engine
This is Rietveld 408576698