Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 12217156: Add --force to pub lish. (Closed)

Created:
7 years, 10 months ago by Bob Nystrom
Modified:
7 years, 10 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add --force to pub lish. BUG=http://code.google.com/p/dart/issues/detail?id=8487 Committed: https://code.google.com/p/dart/source/detail?r=18423

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -9 lines) Patch
M utils/pub/command_lish.dart View 7 chunks +22 lines, -4 lines 0 comments Download
M utils/tests/pub/pub_lish_test.dart View 4 chunks +76 lines, -3 lines 0 comments Download
M utils/tests/pub/pub_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M utils/tests/pub/test_pub.dart View 1 chunk +3 lines, -1 line 2 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
7 years, 10 months ago (2013-02-13 00:10:55 UTC) #1
nweiz
lgtm https://codereview.chromium.org/12217156/diff/1/utils/tests/pub/test_pub.dart File utils/tests/pub/test_pub.dart (right): https://codereview.chromium.org/12217156/diff/1/utils/tests/pub/test_pub.dart#newcode737 utils/tests/pub/test_pub.dart:737: if (expected.last.trim() == '') { Are there cases ...
7 years, 10 months ago (2013-02-13 00:23:32 UTC) #2
Bob Nystrom
7 years, 10 months ago (2013-02-13 00:52:58 UTC) #3
Thanks!

https://codereview.chromium.org/12217156/diff/1/utils/tests/pub/test_pub.dart
File utils/tests/pub/test_pub.dart (right):

https://codereview.chromium.org/12217156/diff/1/utils/tests/pub/test_pub.dart...
utils/tests/pub/test_pub.dart:737: if (expected.last.trim() == '') {
On 2013/02/13 00:23:32, nweiz wrote:
> Are there cases where we're not printing trailing newlines? We should probably
> fix them if so.

I don't think so. The 'if' here allows you to validate a single line of output
using:

  output: "Blah"

instead of:

  output: "Blah\n"

which is what you had to do before. That made sense if you had a multiline
string where the closing """ was on its own line, but it's a drag for single
line ones.

I know we can use RegExp instead to avoid those, but that bugs me for cases
where I do just want to validate a literal string. I hate having to escape regex
metacharacters there.

Powered by Google App Engine
This is Rietveld 408576698