Unit test improvements:

Unit test improvements:

When doing equality tests, if two items have a different type but the same toString() represenation it can be hard to figure out the difference; we now include type info.
See https://code.google.com/p/dart/issues/detail?id=6816

If callbacks are not anonymous we include their names in error messages.

Throws matchers will fail now on arguments that are not Functions or Futures.
See https://code.google.com/p/dart/issues/detail?id=6761

Fix initial comment on how to use unittest; see issue https://code.google.com/p/dart/issues/detail?id=7835

The verbose flag to expect worked to show contents of Iterables but not Maps; fixed that.
Committed: https://code.google.com/p/dart/source/detail?r=18401

[Siggi Cherem (dart-lang), 2013-02-12 20:48:51]

lgtm

https://codereview.chromium.org/12217142/diff/1/pkg/unittest/lib/src/core_mat...
File pkg/unittest/lib/src/core_matchers.dart (right):

https://codereview.chromium.org/12217142/diff/1/pkg/unittest/lib/src/core_mat...
pkg/unittest/lib/src/core_matchers.dart:332: return false;
nit: given that this is fast-exit code, it might be nice to see it upfront:

bool matches(item, ...) {
  if (item is! Function && item is! Future) return false;
  if (item is Future) {
    ...
  }

[gram, 2013-02-12 20:59:30]

PTAL at expect.dart; I added a change there that I don't think made it in time
for your review.

https://codereview.chromium.org/12217142/diff/1/pkg/unittest/lib/src/core_mat...
File pkg/unittest/lib/src/core_matchers.dart (right):

https://codereview.chromium.org/12217142/diff/1/pkg/unittest/lib/src/core_mat...
pkg/unittest/lib/src/core_matchers.dart:332: return false;
On 2013/02/12 20:48:51, Siggi Cherem (dart-lang) wrote:
> nit: given that this is fast-exit code, it might be nice to see it upfront:
> 
> bool matches(item, ...) {
>   if (item is! Function && item is! Future) return false;
>   if (item is Future) {
>     ...
>   }

Done.

[Siggi Cherem (dart-lang), 2013-02-12 21:06:15]

lgtm

https://codereview.chromium.org/12217142/diff/6001/pkg/unittest/lib/src/expec...
File pkg/unittest/lib/src/expect.dart (right):

https://codereview.chromium.org/12217142/diff/6001/pkg/unittest/lib/src/expec...
pkg/unittest/lib/src/expect.dart:130: var count = 25;
seems quite arbitrary to use 25 =)... maybe 10? (especially since there is 1 per
line?)

https://codereview.chromium.org/12217142/diff/6001/pkg/unittest/lib/src/expec...
pkg/unittest/lib/src/expect.dart:131: for (var k in actual.keys) {
Is this description used for any other purpose? Will it matter that keys are not
guaranteed to any particular order?

[Siggi Cherem (dart-lang), 2013-02-12 21:07:09]

https://codereview.chromium.org/12217142/diff/6001/pkg/unittest/lib/src/core_...
File pkg/unittest/lib/src/core_matchers.dart (right):

https://codereview.chromium.org/12217142/diff/6001/pkg/unittest/lib/src/core_...
pkg/unittest/lib/src/core_matchers.dart:331: } else if (item is! Function) {
btw seems that the fix didn't make it to this patch.

[gram, 2013-02-12 21:08:09]

https://codereview.chromium.org/12217142/diff/6001/pkg/unittest/lib/src/expec...
File pkg/unittest/lib/src/expect.dart (right):

https://codereview.chromium.org/12217142/diff/6001/pkg/unittest/lib/src/expec...
pkg/unittest/lib/src/expect.dart:130: var count = 25;
On 2013/02/12 21:06:15, Siggi Cherem (dart-lang) wrote:
> seems quite arbitrary to use 25 =)... maybe 10? (especially since there is 1
per
> line?)

As you say, it is arbitrary. 10 feels too small for me though.

https://codereview.chromium.org/12217142/diff/6001/pkg/unittest/lib/src/expec...
pkg/unittest/lib/src/expect.dart:131: for (var k in actual.keys) {
On 2013/02/12 21:06:15, Siggi Cherem (dart-lang) wrote:
> Is this description used for any other purpose? Will it matter that keys are
not
> guaranteed to any particular order?

No. Unlike the matcher description; this is the error description.