Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 12217124: Removing deprecated events syntax. (Closed)

Created:
7 years, 10 months ago by blois
Modified:
7 years, 10 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Removing deprecated events syntax. BUG= Committed: https://code.google.com/p/dart/source/detail?r=18459

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -3241 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 64 chunks +15 lines, -1252 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 64 chunks +9 lines, -1237 lines 0 comments Download
M sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart View 8 chunks +0 lines, -82 lines 0 comments Download
M sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 8 chunks +0 lines, -82 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 2 chunks +0 lines, -133 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 2 chunks +0 lines, -133 lines 0 comments Download
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 2 chunks +0 lines, -16 lines 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 2 chunks +0 lines, -16 lines 0 comments Download
M tools/dom/scripts/htmleventgenerator.py View 2 chunks +0 lines, -234 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/dom/src/Isolates.dart View 1 3 chunks +7 lines, -10 lines 0 comments Download
M tools/dom/templates/html/impl/impl_EventTarget.darttemplate View 1 1 chunk +2 lines, -39 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
blois
7 years, 10 months ago (2013-02-12 01:03:16 UTC) #1
Emily Fortuna
lgtm!
7 years, 10 months ago (2013-02-12 01:40:17 UTC) #2
blois
I missed removing some of the EventTarget APIs, which exposed an issue in the JS ...
7 years, 10 months ago (2013-02-12 02:06:34 UTC) #3
Emily Fortuna
lgtm. Don't we need the on['foo'] syntax for referencing custom events, anyway? Or is there ...
7 years, 10 months ago (2013-02-12 17:49:40 UTC) #4
blois
7 years, 10 months ago (2013-02-12 18:02:04 UTC) #5
On 2013/02/12 17:49:40, Emily Fortuna wrote:
> lgtm. Don't we need the on['foo'] syntax for referencing custom events,
anyway?
> Or is there a better way to do that?

Recommended way is to declare an EventStreamProvider, to avoid the dependency on
strings and easily capture bubbling events.

Powered by Google App Engine
This is Rietveld 408576698