Issue 12217122: Re-submit r18349.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12217122: Re-submit r18349. (Closed)

Created:
7 years, 10 months ago by nweiz

Modified:
7 years, 10 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Re-submit r18349. This should hopefully guard against the race condition introduced by extremely slow CPU time. Committed: https://code.google.com/p/dart/source/detail?r=18361

Patch Set 2 : Code review change #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+176 lines, -49 lines)			Patch
M	pkg/scheduled_test/lib/scheduled_test.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/scheduled_test/lib/src/schedule.dart	View		8 chunks	+53 lines, -14 lines	0 comments	Download
M	pkg/scheduled_test/lib/src/utils.dart	View	1	1 chunk	+12 lines, -2 lines	0 comments	Download
M	pkg/scheduled_test/test/scheduled_test_test.dart	View		4 chunks	+108 lines, -30 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

One nit, then LGTM. https://codereview.chromium.org/12217122/diff/1/pkg/scheduled_test/lib/src/utils.dart File pkg/scheduled_test/lib/src/utils.dart (right): https://codereview.chromium.org/12217122/diff/1/pkg/scheduled_test/lib/src/utils.dart#newcode22 pkg/scheduled_test/lib/src/utils.dart:22: /// This pumps the event ...

7 years, 10 months ago (2013-02-12 00:35:19 UTC) #2

nweiz

7 years, 10 months ago (2013-02-12 00:52:19 UTC) #3

https://codereview.chromium.org/12217122/diff/1/pkg/scheduled_test/lib/src/ut...
File pkg/scheduled_test/lib/src/utils.dart (right):

https://codereview.chromium.org/12217122/diff/1/pkg/scheduled_test/lib/src/ut...
pkg/scheduled_test/lib/src/utils.dart:22: /// This pumps the event loop after
every second of sleeping. This should ensure
On 2013/02/12 00:35:19, Bob Nystrom wrote:
> second -> millisecond.

Done.

Expand Messages | Collapse Messages

Issue 12217122: Re-submit r18349. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Code review change #

Messages