Issue 12217089: Allow non-primitive-value dictionaries to be passed to constructors for html

Issue 12217089: Allow non-primitive-value dictionaries to be passed to constructors for html (Closed)

Created:
7 years, 10 months ago by Emily Fortuna

Modified:
7 years, 10 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow non-primitive-value dictionaries to be passed to constructors for html types. BUG= Committed: https://code.google.com/p/dart/source/detail?r=18320

Patch Set 1 : #

Total comments: 4

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+250 lines, -78 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	15 chunks	+74 lines, -44 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	8 chunks	+16 lines, -0 lines	0 comments	Download
M	tests/html/html.status	View	4 chunks	+4 lines, -0 lines	0 comments	Download
M	tests/html/notifications_test.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	tests/html/rtc_test.dart	View	1 chunk	+45 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/generator.py	View	5 chunks	+21 lines, -6 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	2 chunks	+12 lines, -6 lines	0 comments	Download
A	tools/dom/templates/html/dart2js/impl_Notification.darttemplate	View	1 chunk	+18 lines, -0 lines	1 comment	Download
A +	tools/dom/templates/html/dart2js/impl_RTCIceCandidate.darttemplate	View	1 chunk	+5 lines, -11 lines	1 comment	Download
A	tools/dom/templates/html/dart2js/impl_RTCPeerConnection.darttemplate	View	1 chunk	+44 lines, -0 lines	1 comment	Download
A +	tools/dom/templates/html/dart2js/impl_RTCSessionDescription.darttemplate	View	1 chunk	+5 lines, -11 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

Long overdue fix for http://code.google.com/p/dart/issues/detail?id=7030

7 years, 10 months ago (2013-02-09 03:19:46 UTC) #1

blois

7 years, 10 months ago (2013-02-11 17:24:32 UTC) #2

lgtm

https://codereview.chromium.org/12217089/diff/7001/tools/dom/templates/html/d...
File tools/dom/templates/html/dart2js/impl_Notification.darttemplate (right):

https://codereview.chromium.org/12217089/diff/7001/tools/dom/templates/html/d...
tools/dom/templates/html/dart2js/impl_Notification.darttemplate:7: /// @domName
$DOMNAME; @docsEditable true$ANNOTATIONS
Only ANNOTATIONS, no comments.

https://codereview.chromium.org/12217089/diff/7001/tools/dom/templates/html/d...
File tools/dom/templates/html/dart2js/impl_RTCIceCandidate.darttemplate (right):

https://codereview.chromium.org/12217089/diff/7001/tools/dom/templates/html/d...
tools/dom/templates/html/dart2js/impl_RTCIceCandidate.darttemplate:7: ///
@domName $DOMNAME; @docsEditable true$ANNOTATIONS
Only $ANNOTATIONS, no comments.

https://codereview.chromium.org/12217089/diff/7001/tools/dom/templates/html/d...
File tools/dom/templates/html/dart2js/impl_RTCPeerConnection.darttemplate
(right):

https://codereview.chromium.org/12217089/diff/7001/tools/dom/templates/html/d...
tools/dom/templates/html/dart2js/impl_RTCPeerConnection.darttemplate:7: ///
@domName $DOMNAME; @docsEditable true$ANNOTATIONS
Should only have $ANNOTATIONS (no comments).

https://codereview.chromium.org/12217089/diff/7001/tools/dom/templates/html/d...
File tools/dom/templates/html/dart2js/impl_RTCSessionDescription.darttemplate
(right):

https://codereview.chromium.org/12217089/diff/7001/tools/dom/templates/html/d...
tools/dom/templates/html/dart2js/impl_RTCSessionDescription.darttemplate:7: ///
@domName $DOMNAME; @docsEditable true$ANNOTATIONS
Ditto.

Expand Messages | Collapse Messages