Issue 12217045: Move test_controller.js inside unitest/lib so it can be used in external tests

Issue 12217045: Move test_controller.js inside unitest/lib so it can be used in external tests (Closed)

Created:
7 years, 10 months ago by Siggi Cherem (dart-lang)

Modified:
7 years, 10 months ago

Reviewers:
ricow1, Bill Hesse, gram, ahe, kustermann

CC:
reviews_dartlang.org, ahe

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move test_controller.js inside unitest/lib so it can be used in external tests too. Committed: https://code.google.com/p/dart/source/detail?r=18184

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -323 lines)			Patch
D	pkg/unittest/coverage_controller.js	View	1 chunk	+0 lines, -31 lines	0 comments	Download
A +	pkg/unittest/lib/coverage_controller.js	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	pkg/unittest/lib/test_controller.js	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	pkg/unittest/static/coverage_controller.js	View	1 chunk	+0 lines, -31 lines	0 comments	Download
D	pkg/unittest/static/test_controller.js	View	1 chunk	+0 lines, -120 lines	0 comments	Download
D	pkg/unittest/test_controller.js	View	1 chunk	+0 lines, -142 lines	0 comments	Download
M	tools/testing/dart/browser_test.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

On 2013/02/06 21:02:40, ahe wrote: FYI - turns out that dartium has tests depending on ...

7 years, 10 months ago (2013-02-06 21:07:12 UTC) #4

Siggi Cherem (dart-lang)

On 2013/02/06 21:07:12, Siggi Cherem (dart-lang) wrote: > On 2013/02/06 21:02:40, ahe wrote: > > ...

7 years, 10 months ago (2013-02-06 21:08:07 UTC) #5

ricow1

7 years, 10 months ago (2013-02-07 09:21:35 UTC) #6

Message was sent while issue was closed.

On 2013/02/06 21:07:12, Siggi Cherem (dart-lang) wrote:
> On 2013/02/06 21:02:40, ahe wrote:
> 
> FYI - turns out that dartium has tests depending on test_controller as well,
so
> we have to fix the repo there too. Meanwhile I'm partially reverting things
> here:
> - I'm adding test_controller.js in pkg/unittest/ back
> - I'm keeping it inside lib so it is available externally
> - I'm not sure what is the prupose of the version under static/, is that used
I raised the same question here:
https://codereview.chromium.org/10907245/


> anywhere?

Expand Messages | Collapse Messages