Issue 12217036: Check arguments counts.

Issue 12217036: Check arguments counts. (Closed)

Created:
7 years, 10 months ago by Johnni Winther

Modified:
7 years, 10 months ago

Reviewers:
karlklose, kasperl

CC:
reviews_dartlang.org, ahe

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Check arguments counts. Committed: https://code.google.com/p/dart/source/detail?r=18170

Patch Set 2 : Analyze additional arguments. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+134 lines, -10 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart_types.dart	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/foreign_helper.dart	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/typechecker.dart	View	1	2 chunks	+43 lines, -8 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/warnings.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/type_checker_test.dart	View		2 chunks	+72 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/12217036/diff/1/sdk/lib/_internal/compiler/implementation/typechecker.dart File sdk/lib/_internal/compiler/implementation/typechecker.dart (right): https://codereview.chromium.org/12217036/diff/1/sdk/lib/_internal/compiler/implementation/typechecker.dart#newcode288 sdk/lib/_internal/compiler/implementation/typechecker.dart:288: checkAssignable(argument, namedParameterType, analyze(argument)); Would it make sense to ...

7 years, 10 months ago (2013-02-06 11:34:55 UTC) #2

Johnni Winther

https://codereview.chromium.org/12217036/diff/1/sdk/lib/_internal/compiler/implementation/typechecker.dart File sdk/lib/_internal/compiler/implementation/typechecker.dart (right): https://codereview.chromium.org/12217036/diff/1/sdk/lib/_internal/compiler/implementation/typechecker.dart#newcode288 sdk/lib/_internal/compiler/implementation/typechecker.dart:288: checkAssignable(argument, namedParameterType, analyze(argument)); On 2013/02/06 11:34:55, kasperl wrote: > ...

7 years, 10 months ago (2013-02-06 13:33:01 UTC) #3

Message was sent while issue was closed.

LGTM.

Expand Messages | Collapse Messages