Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1221683005: Add lock prefix and cmpxchg to X64 disassembler. (Closed)

Created:
5 years, 5 months ago by rmacnak
Modified:
5 years, 5 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add lock prefix and cmpxchg to X64 disassembler. (Used in UpdateStoreBuffer stub.) R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/3853a4e9b27a183bca7bc6163d58766b17f356fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M runtime/vm/disassembler_x64.cc View 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 5 months ago (2015-06-29 21:41:40 UTC) #2
srdjan
lgtm
5 years, 5 months ago (2015-06-30 00:10:07 UTC) #3
rmacnak
5 years, 5 months ago (2015-06-30 00:20:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3853a4e9b27a183bca7bc6163d58766b17f356fa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698