Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1221333015: dart2js: Move field-visiting code to the program-builder. (Closed)

Created:
5 years, 5 months ago by floitsch
Modified:
5 years, 5 months ago
Reviewers:
herhut
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Move field-visiting code to the program-builder. R=herhut@google.com Committed: https://github.com/dart-lang/sdk/commit/c45c5c8578c8f37c3ba4f08bb425afb62820d72c

Patch Set 1 #

Patch Set 2 : Change order. #

Total comments: 3

Patch Set 3 : Remove bad show line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -169 lines) Patch
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart View 2 chunks +0 lines, -130 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/declarations.dart View 1 chunk +0 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/collector.dart View 3 chunks +3 lines, -7 lines 0 comments Download
A pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart View 1 1 chunk +170 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 2 5 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
https://codereview.chromium.org/1221333015/diff/20001/pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart File pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart (right): https://codereview.chromium.org/1221333015/diff/20001/pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart#newcode5 pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart:5: part of dart2js.js_emitter.program_builder; This file has practically no new ...
5 years, 5 months ago (2015-07-08 11:09:46 UTC) #2
herhut
lgtm https://codereview.chromium.org/1221333015/diff/20001/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart File pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart (right): https://codereview.chromium.org/1221333015/diff/20001/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart#newcode29 pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart:29: ClosureFieldElement, I don't think this exists in elements.dart?
5 years, 5 months ago (2015-07-09 13:28:39 UTC) #3
floitsch
https://codereview.chromium.org/1221333015/diff/20001/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart File pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart (right): https://codereview.chromium.org/1221333015/diff/20001/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart#newcode29 pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart:29: ClosureFieldElement, On 2015/07/09 13:28:39, herhut wrote: > I don't ...
5 years, 5 months ago (2015-07-09 13:50:25 UTC) #4
floitsch
5 years, 5 months ago (2015-07-09 13:51:57 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
c45c5c8578c8f37c3ba4f08bb425afb62820d72c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698