Fixing CharacterData.remove not working on FireFox.

Fixing CharacterData.remove not working on FireFox.

CharacterData was overriding remove, but was not supported on FF, so just removed the override.

BUG=7173
Committed: https://code.google.com/p/dart/source/detail?r=18201

[Siggi Cherem (dart-lang), 2013-02-07 00:52:33]

lgtm

https://codereview.chromium.org/12213058/diff/5001/sdk/lib/html/dartium/html_...
File sdk/lib/html/dartium/html_dartium.dart (left):

https://codereview.chromium.org/12213058/diff/5001/sdk/lib/html/dartium/html_...
sdk/lib/html/dartium/html_dartium.dart:2032: -  void remove() native
"CharacterData_remove_Callback";
seems that you could keep the override in dartium, unless the scripts are very
symmetrical about it what's in dart2js and dartium.

Alternatively, we could inspect if the method is there use it, otherwise use the
super method.

[blois, 2013-02-07 01:13:11]

On 2013/02/07 00:52:33, Siggi Cherem (dart-lang) wrote:
> lgtm
> 
>
https://codereview.chromium.org/12213058/diff/5001/sdk/lib/html/dartium/html_...
> File sdk/lib/html/dartium/html_dartium.dart (left):
> 
>
https://codereview.chromium.org/12213058/diff/5001/sdk/lib/html/dartium/html_...
> sdk/lib/html/dartium/html_dartium.dart:2032: -  void remove() native
> "CharacterData_remove_Callback";
> seems that you could keep the override in dartium, unless the scripts are very
> symmetrical about it what's in dart2js and dartium.
> 
> Alternatively, we could inspect if the method is there use it, otherwise use
the
> super method.

Since they should all do the same thing, I prefer to remove this method and fall
back to the single implementation. Unless there is a compelling reason to use
the native one (performance?)