Issue 12213020: Remember owner class of patch code

Issue 12213020: Remember owner class of patch code (Closed)

Created:
7 years, 10 months ago by hausner

Modified:
7 years, 10 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Remember owner class of patch code This is a step towards using PatchClass for mixins Committed: https://code.google.com/p/dart/source/detail?r=18155

Patch Set 2 : #

Total comments: 4

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -13 lines)			Patch
M	runtime/vm/object.h	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	4 chunks	+13 lines, -8 lines	4 comments	Download
M	runtime/vm/raw_object.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with 2 changes. -Ivan https://codereview.chromium.org/12213020/diff/6001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/12213020/diff/6001/runtime/vm/object.cc#newcode1826 runtime/vm/object.cc:1826: At this point the ...

7 years, 10 months ago (2013-02-05 21:14:02 UTC) #3

Ivan Posva

https://codereview.chromium.org/12213020/diff/6001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/12213020/diff/6001/runtime/vm/object.cc#newcode1826 runtime/vm/object.cc:1826: On 2013/02/05 21:14:02, Ivan Posva wrote: > At this ...

7 years, 10 months ago (2013-02-05 21:16:08 UTC) #4

Message was sent while issue was closed.

Will do in follow=up checkin.

Expand Messages | Collapse Messages