Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 12212211: Reapply "New implementation of {,Linked}Hash{Set,Map}." (Closed)

Created:
7 years, 10 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply "New implementation of {,Linked}Hash{Set,Map}." Committed: https://code.google.com/p/dart/source/detail?r=18573

Patch Set 1 #

Patch Set 2 : Fix breaks in pub. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1693 lines, -600 lines) Patch
M pkg/pkg.status View 1 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/native_handler.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/source_map_builder.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/collection/collection.dart View 1 chunk +6 lines, -2 lines 0 comments Download
M sdk/lib/collection/collection_sources.gypi View 1 chunk +6 lines, -2 lines 0 comments Download
A sdk/lib/collection/hash_map.dart View 1 chunk +136 lines, -0 lines 0 comments Download
A sdk/lib/collection/hash_set.dart View 1 chunk +115 lines, -0 lines 0 comments Download
A sdk/lib/collection/hash_table.dart View 1 chunk +404 lines, -0 lines 0 comments Download
A sdk/lib/collection/linked_hash_map.dart View 1 chunk +138 lines, -0 lines 0 comments Download
A sdk/lib/collection/linked_hash_set.dart View 1 chunk +157 lines, -0 lines 0 comments Download
A sdk/lib/collection/linked_hash_table.dart View 1 chunk +165 lines, -0 lines 0 comments Download
D sdk/lib/collection/map.dart View 1 chunk +0 lines, -474 lines 0 comments Download
D sdk/lib/collection/set.dart View 1 chunk +0 lines, -110 lines 0 comments Download
M sdk/lib/core/map.dart View 2 chunks +5 lines, -0 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 chunk +17 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +17 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +17 lines, -0 lines 0 comments Download
A tests/corelib/hash_map2_test.dart View 1 chunk +289 lines, -0 lines 0 comments Download
A tests/corelib/hash_set_test.dart View 1 chunk +206 lines, -0 lines 0 comments Download
M tests/corelib/map_from_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/pub.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein Nielsen
TBR
7 years, 10 months ago (2013-02-15 13:04:39 UTC) #1
floitsch
7 years, 10 months ago (2013-02-15 13:08:21 UTC) #2
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698