Issue 12212194: IO v2: Use a single PathBuffer in Directory.list on Windows, and stop rewriting paths during listin…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12212194: IO v2: Use a single PathBuffer in Directory.list on Windows, and stop rewriting paths during listin… (Closed)

Created:
7 years, 10 months ago by Bill Hesse

Modified:
7 years, 10 months ago

Reviewers:
Anders Johnsen, Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

IO v2: Use a single PathBuffer in Directory.list on Windows, and stop rewriting paths during listing. Committed: https://code.google.com/p/dart/source/detail?r=18740

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -79 lines)			Patch
	M	runtime/bin/directory_win.cc	View	1	14 chunks	+46 lines, -79 lines	0 comments	Download

Total messages: 2 (0 generated)

Bill Hesse

This is the Windows version of CL https://codereview.chromium.org/12217086/

7 years, 10 months ago (2013-02-15 14:21:05 UTC) #1

lgtm