Issue 12212147: Fix break in checked mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12212147: Fix break in checked mode. (Closed)

Created:
7 years, 10 months ago by gram

Modified:
7 years, 10 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix break in checked mode. Committed: https://code.google.com/p/dart/source/detail?r=18404

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
		pkg/unittest/lib/src/core_matchers.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm https://codereview.chromium.org/12212147/diff/1/pkg/unittest/lib/src/core_matchers.dart File pkg/unittest/lib/src/core_matchers.dart (right): https://codereview.chromium.org/12212147/diff/1/pkg/unittest/lib/src/core_matchers.dart#newcode189 pkg/unittest/lib/src/core_matchers.dart:189: reason..add(actual.runtimeType.toString()).add(':'); .. to .? or change the one ...

7 years, 10 months ago (2013-02-12 21:23:52 UTC) #2

gram

7 years, 10 months ago (2013-02-12 21:25:41 UTC) #3

https://codereview.chromium.org/12212147/diff/1/pkg/unittest/lib/src/core_mat...
File pkg/unittest/lib/src/core_matchers.dart (right):

https://codereview.chromium.org/12212147/diff/1/pkg/unittest/lib/src/core_mat...
pkg/unittest/lib/src/core_matchers.dart:189:
reason..add(actual.runtimeType.toString()).add(':');
On 2013/02/12 21:23:52, Siggi Cherem (dart-lang) wrote:
> .. to .? or change the one in 183 to be .. as well?

Done.

Expand Messages | Collapse Messages

Issue 12212147: Fix break in checked mode. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages