Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 12212129: Fix bug in ListQueue.from. (Closed)

Created:
7 years, 10 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix bug in ListQueue.from. BUG=http://dartbug.com/8484 Committed: https://code.google.com/p/dart/source/detail?r=18380

Patch Set 1 #

Patch Set 2 : Add assert. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M sdk/lib/collection/queue.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests/corelib/queue_test.dart View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
7 years, 10 months ago (2013-02-12 09:55:58 UTC) #1
Lasse Reichstein Nielsen
+floitsch
7 years, 10 months ago (2013-02-12 12:13:59 UTC) #2
Anders Johnsen
LGTM
7 years, 10 months ago (2013-02-12 12:27:28 UTC) #3
floitsch
7 years, 10 months ago (2013-02-12 14:24:29 UTC) #4
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698