Issue 12212074: Support for non-DOM canvases/contexts (backed by bitaps).

Issue 12212074: Support for non-DOM canvases/contexts (backed by bitaps). (Closed)

Created:
7 years, 10 months ago by gram

Modified:
7 years, 10 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Support for non-DOM canvases/contexts (backed by bitmaps). Also updated to work with recent Skia CL 7640. Committed: https://code.google.com/p/dart/source/detail?r=18279

Patch Set 2 : #

Total comments: 2

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+209 lines, -163 lines)			Patch
M	runtime/embedders/openglui/common/canvas_context.h	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	runtime/embedders/openglui/common/canvas_context.cc	View		2 chunks	+45 lines, -24 lines	0 comments	Download
M	runtime/embedders/openglui/common/canvas_state.cc	View		2 chunks	+31 lines, -31 lines	0 comments	Download
M	runtime/embedders/openglui/common/extension.cc	View		2 chunks	+1 line, -16 lines	0 comments	Download
M	runtime/embedders/openglui/common/gl.dart	View		4 chunks	+15 lines, -9 lines	2 comments	Download
M	runtime/embedders/openglui/common/graphics_handler.h	View		1 chunk	+2 lines, -6 lines	0 comments	Download
M	runtime/embedders/openglui/common/graphics_handler.cc	View	1	2 chunks	+22 lines, -7 lines	0 comments	Download
M	runtime/embedders/openglui/openglui_embedder.gypi	View	1	2 chunks	+8 lines, -2 lines	0 comments	Download
M	samples/openglui/android/android.gyp	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	samples/openglui/android/custom_rules.xml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	samples/openglui/src/gl.dart	View		1 chunk	+22 lines, -2 lines	0 comments	Download
M	samples/openglui/src/openglui_canvas_tests.dart	View		3 chunks	+50 lines, -37 lines	0 comments	Download
M	samples/openglui/web/gl_driver.dart	View		1 chunk	+7 lines, -23 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

vsm

lgtm https://codereview.chromium.org/12212074/diff/8001/runtime/embedders/openglui/common/gl.dart File runtime/embedders/openglui/common/gl.dart (right): https://codereview.chromium.org/12212074/diff/8001/runtime/embedders/openglui/common/gl.dart#newcode588 runtime/embedders/openglui/common/gl.dart:588: C2DDrawImage(_handle, element.src.toString(), 0, 0, false, w, h, isn't ...

7 years, 10 months ago (2013-02-08 22:11:06 UTC) #3

gram

7 years, 10 months ago (2013-02-09 01:37:39 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/12212074/diff/8001/runtime/embedders/openglui...
File runtime/embedders/openglui/common/gl.dart (right):

https://codereview.chromium.org/12212074/diff/8001/runtime/embedders/openglui...
runtime/embedders/openglui/common/gl.dart:588: C2DDrawImage(_handle,
element.src.toString(), 0, 0, false, w, h,
On 2013/02/08 22:11:06, vsm wrote:
> isn't element.src already a String?

Just playing safe.... but I'll remove it.

Expand Messages | Collapse Messages