Sample test for custom elements.

Sample test for custom elements.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=18421

[blois, 2013-02-07 01:11:40]

As we discussed a while back, an example test for registering custom elements.

Consider this a strawman proposal, feel free to push back.

[Jennifer Messerly, 2013-02-07 02:08:08]

This looks really cool. Seems like a great way to start making progress.

[Anton Muhin, 2013-02-07 15:29:33]

https://codereview.chromium.org/12212056/diff/7/tests/html/custom_elements_te...
File tests/html/custom_elements_test.dart (right):

https://codereview.chromium.org/12212056/diff/7/tests/html/custom_elements_te...
tests/html/custom_elements_test.dart:67: expect(element, isNotNull);
there is no element local.  how and when you're fetching it?

[Siggi Cherem (dart-lang), 2013-02-07 17:29:39]

looks great, is the idea to include also the other lifecycle methods in Element
(onInserted, onRemoved)

https://codereview.chromium.org/12212056/diff/7/tests/html/custom_elements_te...
File tests/html/custom_elements_test.dart (right):

https://codereview.chromium.org/12212056/diff/7/tests/html/custom_elements_te...
tests/html/custom_elements_test.dart:25: var element = new
Element.tag('x-type');
shoudln't this be x-type1?

[blois, 2013-02-07 21:15:06]

For lifecycle events- is this something which is poly-filled right now in web
components?

https://codereview.chromium.org/12212056/diff/7/tests/html/custom_elements_te...
File tests/html/custom_elements_test.dart (right):

https://codereview.chromium.org/12212056/diff/7/tests/html/custom_elements_te...
tests/html/custom_elements_test.dart:25: var element = new
Element.tag('x-type');
On 2013/02/07 17:29:39, Siggi Cherem (dart-lang) wrote:
> shoudln't this be x-type1?

Done.

https://codereview.chromium.org/12212056/diff/7/tests/html/custom_elements_te...
tests/html/custom_elements_test.dart:67: expect(element, isNotNull);
On 2013/02/07 15:29:33, Anton Muhin wrote:
> there is no element local.  how and when you're fetching it?

Done.

[Siggi Cherem (dart-lang), 2013-02-07 21:50:26]

On 2013/02/07 21:15:06, blois wrote:
> For lifecycle events- is this something which is poly-filled right now in web
> components?
> 
yeah, we also polyfill the create event right now.

>
https://codereview.chromium.org/12212056/diff/7/tests/html/custom_elements_te...
> File tests/html/custom_elements_test.dart (right):
> 
>
https://codereview.chromium.org/12212056/diff/7/tests/html/custom_elements_te...
> tests/html/custom_elements_test.dart:25: var element = new
> Element.tag('x-type');
> On 2013/02/07 17:29:39, Siggi Cherem (dart-lang) wrote:
> > shoudln't this be x-type1?
> 
> Done.
> 
>
https://codereview.chromium.org/12212056/diff/7/tests/html/custom_elements_te...
> tests/html/custom_elements_test.dart:67: expect(element, isNotNull);
> On 2013/02/07 15:29:33, Anton Muhin wrote:
> > there is no element local.  how and when you're fetching it?
> 
> Done.

[Anton Muhin, 2013-02-08 12:51:03]

https://codereview.chromium.org/12212056/diff/6001/tests/html/custom_elements...
File tests/html/custom_elements_test.dart (right):

https://codereview.chromium.org/12212056/diff/6001/tests/html/custom_elements...
tests/html/custom_elements_test.dart:67: element = dom.children[0];
what if I fetch element before document.register call?

[blois, 2013-02-08 17:44:30]

https://codereview.chromium.org/12212056/diff/6001/tests/html/custom_elements...
File tests/html/custom_elements_test.dart (right):

https://codereview.chromium.org/12212056/diff/6001/tests/html/custom_elements...
tests/html/custom_elements_test.dart:67: element = dom.children[0];
On 2013/02/08 12:51:03, Anton Muhin wrote:
> what if I fetch element before document.register call?

Added checks, it should be an UnknownElement. After document.register, fetching
the element will return the proper type. But the element originally fetched
remains unchanged (but is un-parented).

[Anton Muhin, 2013-02-11 14:04:30]

lgtm

https://codereview.chromium.org/12212056/diff/8002/tests/html/custom_elements...
File tests/html/custom_elements_test.dart (right):

https://codereview.chromium.org/12212056/diff/8002/tests/html/custom_elements...
tests/html/custom_elements_test.dart:70: var postElement = dom.children[0];
weird semantics.  I wonder what happens in case of various queries which return
NodeLists---those lists are cached sometimes.

And it might be a good idea to add some tests for event listeners---I'd suspect
that registration should do something to them if one can install a listener on
unknown element in the first place.

[blois, 2013-02-12 00:46:18]

On 2013/02/11 14:04:30, Anton Muhin wrote:
> lgtm
> 
>
https://codereview.chromium.org/12212056/diff/8002/tests/html/custom_elements...
> File tests/html/custom_elements_test.dart (right):
> 
>
https://codereview.chromium.org/12212056/diff/8002/tests/html/custom_elements...
> tests/html/custom_elements_test.dart:70: var postElement = dom.children[0];
> weird semantics.  I wonder what happens in case of various queries which
return
> NodeLists---those lists are cached sometimes.
> 
> And it might be a good idea to add some tests for event listeners---I'd
suspect
> that registration should do something to them if one can install a listener on
> unknown element in the first place.

Agree, it's a bit weird.

Siggi/John- do you guys know what the plan is for event handlers added before
the element has been registered?

[Jennifer Messerly, 2013-02-12 00:51:57]

On 2013/02/12 00:46:18, blois wrote:
> On 2013/02/11 14:04:30, Anton Muhin wrote:
> > lgtm
> > 
> >
>
https://codereview.chromium.org/12212056/diff/8002/tests/html/custom_elements...
> > File tests/html/custom_elements_test.dart (right):
> > 
> >
>
https://codereview.chromium.org/12212056/diff/8002/tests/html/custom_elements...
> > tests/html/custom_elements_test.dart:70: var postElement = dom.children[0];
> > weird semantics.  I wonder what happens in case of various queries which
> return
> > NodeLists---those lists are cached sometimes.
> > 
> > And it might be a good idea to add some tests for event listeners---I'd
> suspect
> > that registration should do something to them if one can install a listener
on
> > unknown element in the first place.
> 
> Agree, it's a bit weird.
> 
> Siggi/John- do you guys know what the plan is for event handlers added before
> the element has been registered?

Not sure. It used to be covered in element upgrade, but now the spec says "needs
to be rewritten"
https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/custom/index.html#dfn-...

As I remember it: I don't think event handlers were kept. As soon as the
HTMLUnknownElement was replaced with the real one, everything about the wrapper
was thrown out except things from the HTML document, i.e. attributes and
children.

[blois, 2013-02-13 00:37:12]

On 2013/02/12 00:51:57, John Messerly wrote:
> On 2013/02/12 00:46:18, blois wrote:
> > On 2013/02/11 14:04:30, Anton Muhin wrote:
> > > lgtm
> > > 
> > >
> >
>
https://codereview.chromium.org/12212056/diff/8002/tests/html/custom_elements...
> > > File tests/html/custom_elements_test.dart (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/12212056/diff/8002/tests/html/custom_elements...
> > > tests/html/custom_elements_test.dart:70: var postElement =
dom.children[0];
> > > weird semantics.  I wonder what happens in case of various queries which
> > return
> > > NodeLists---those lists are cached sometimes.
> > > 
> > > And it might be a good idea to add some tests for event listeners---I'd
> > suspect
> > > that registration should do something to them if one can install a
listener
> on
> > > unknown element in the first place.
> > 
> > Agree, it's a bit weird.
> > 
> > Siggi/John- do you guys know what the plan is for event handlers added
before
> > the element has been registered?
> 
> Not sure. It used to be covered in element upgrade, but now the spec says
"needs
> to be rewritten"
>
https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/custom/index.html#dfn-...
> 
> As I remember it: I don't think event handlers were kept. As soon as the
> HTMLUnknownElement was replaced with the real one, everything about the
wrapper
> was thrown out except things from the HTML document, i.e. attributes and
> children.

Added a test for event listening & submitted.

[Anton Muhin, 2013-02-13 07:22:35]

just in case if you depend on it, long standing lgtm