Remove Expect from core library.

Remove Expect from core library.

Committed: https://code.google.com/p/dart/source/detail?r=19755
Reverted: http://code.google.com/p/dart/source/detail?r=19756

Committed: https://code.google.com/p/dart/source/detail?r=20996

[floitsch, 2013-02-05 18:54:13]

This CL is not yet complete, but I have all tests except co19.
Please look at your tests (and potentially randomly some others). Most of the
time I switched to using
import 'package:expect/expect.dart'
but in some few cases I just added a "class Expect" that throws an "Error" when
it fails.

There are some tests I wasn't easily able to fix. Please have a look and help me
to migrate them:
@sgjesse, @asiva:
vm/cc/FullSnapshot1

@whesse:
standalone/io/test_extension_fail_test
standalone/io/test_extension_test

Next steps: allow to have an Expect in core and in a package at the same time,
to give the co19 tests time to migrate.

[Lasse Reichstein Nielsen, 2013-02-05 19:35:40]

Does this have to go in a package?
I really like having basic unit-test functionality in the standard library. It
doesn't have to be in dart:core, but how about dart:expect?

[Bob Nystrom, 2013-02-05 19:52:41]

YAML LGTM.

https://codereview.chromium.org/12212016/diff/1/pkg/yaml/test/yaml_test.dart
File pkg/yaml/test/yaml_test.dart (right):

https://codereview.chromium.org/12212016/diff/1/pkg/yaml/test/yaml_test.dart#...
pkg/yaml/test/yaml_test.dart:7: import "package:expect/expect.dart";
YAML should really just be using expect() and not Expect here. It would be great
to change it to just use unittest's API but I understand that may be a bit of
work.

If you don't want to do that, can you add a TODO here to eventually change the
Expect calls to use expect() instead?

[dgrove, 2013-02-05 20:11:12]

On 2013/02/05 19:35:40, Lasse Reichstein Nielsen wrote:
> Does this have to go in a package?
> I really like having basic unit-test functionality in the standard library. It
> doesn't have to be in dart:core, but how about dart:expect?

I don't agree that we should put this in the standard library. At this point,
users of Dart are used to using packages, we should encourage that behavior. I
think we should be extremely careful about adding new dart: libraries, and I
don't believe that expect meets that bar.

[Bob Nystrom, 2013-02-05 20:16:07]

On 2013/02/05 20:11:12, dgrove wrote:
> On 2013/02/05 19:35:40, Lasse Reichstein Nielsen wrote:
> > Does this have to go in a package?
> > I really like having basic unit-test functionality in the standard library.
It
> > doesn't have to be in dart:core, but how about dart:expect?
> 
> I don't agree that we should put this in the standard library. At this point,
> users of Dart are used to using packages, we should encourage that behavior. I
> think we should be extremely careful about adding new dart: libraries, and I
> don't believe that expect meets that bar.

How about:

1. For tests that can't use unittest or import, just use raw Dart code:

if (!someExpection) throw 'fail';

2. For tests that can't use unittest but can use import, just make a library
with the Expect class and do a relative import to get it.

3. For tests that can use import, use pkg/unittest.

I think having two publicly visible unit test packages will confuse users.

[siva, 2013-02-06 02:08:29]

The changes to runtime/vm/dart_api_impl_test.cc and runtime/vm/snapshot_test.cc
LGTM.

I think for most of these small unit tests that we have it might be better to
just add a mini class Expect { ..} in the test instead of the fancy "import
pkg:" stuff.

We need some of these tests to work with minimal infrastructure support.

[Søren Gjesse, 2013-02-06 08:52:51]

lgtm

https://codereview.chromium.org/12212016/diff/1/pkg/expect/pubspec.yaml
File pkg/expect/pubspec.yaml (right):

https://codereview.chromium.org/12212016/diff/1/pkg/expect/pubspec.yaml#newcode1
pkg/expect/pubspec.yaml:1: name: expect
Shouldn't this have a version?

[dgrove, 2013-02-06 15:51:02]

@floitsch - if you do not want this package on pub, please add it to the
blacklist in tools/publish_all_pkgs.py (if this isn't in the blacklist, it will
be uploaded to pub when we do the next trunk build).

On 2013/02/06 08:52:51, Søren Gjesse wrote:
> lgtm
> 
> https://codereview.chromium.org/12212016/diff/1/pkg/expect/pubspec.yaml
> File pkg/expect/pubspec.yaml (right):
> 
>
https://codereview.chromium.org/12212016/diff/1/pkg/expect/pubspec.yaml#newcode1
> pkg/expect/pubspec.yaml:1: name: expect
> Shouldn't this have a version?

[Bill Hesse, 2013-02-07 09:57:39]

Also change tests/standalone/io/test_extension_tester.dart and
test_extension_fail_tester.dart.

LGTM otherwise.

[Lasse Reichstein Nielsen, 2013-02-08 10:45:26]

LGTM with regrets.

[floitsch, 2013-03-09 02:30:41]

Managed to fix the tests I hadn't gotten working last time.

https://codereview.chromium.org/12212016/diff/1/pkg/expect/pubspec.yaml
File pkg/expect/pubspec.yaml (right):

https://codereview.chromium.org/12212016/diff/1/pkg/expect/pubspec.yaml#newcode1
pkg/expect/pubspec.yaml:1: name: expect
On 2013/02/06 08:52:52, Søren Gjesse wrote:
> Shouldn't this have a version?

Copied from logging package. And since we don't intend to publish the package on
pub it shouldn't matter.
Maybe we should even remove the pubspec?

https://codereview.chromium.org/12212016/diff/1/pkg/yaml/test/yaml_test.dart
File pkg/yaml/test/yaml_test.dart (right):

https://codereview.chromium.org/12212016/diff/1/pkg/yaml/test/yaml_test.dart#...
pkg/yaml/test/yaml_test.dart:7: import "package:expect/expect.dart";
On 2013/02/05 19:52:41, Bob Nystrom wrote:
> YAML should really just be using expect() and not Expect here. It would be
great
> to change it to just use unittest's API but I understand that may be a bit of
> work.
> 
> If you don't want to do that, can you add a TODO here to eventually change the
> Expect calls to use expect() instead?

Added TODO.

[floitsch, 2013-03-09 02:49:58]

Committed patchset #2 manually as r19755 (presubmit successful).

[Bill Hesse, 2013-03-10 16:19:55]

https://codereview.chromium.org/12212016/diff/11501/tests/compiler/dart2js_ex...
File tests/compiler/dart2js_extra/super_call_test.dart (right):

https://codereview.chromium.org/12212016/diff/11501/tests/compiler/dart2js_ex...
tests/compiler/dart2js_extra/super_call_test.dart:7: import
"package:expect/expect.dart";
This needs to be moved up.

[floitsch, 2013-03-14 12:50:56]

https://codereview.chromium.org/12212016/diff/11501/tests/compiler/dart2js_ex...
File tests/compiler/dart2js_extra/super_call_test.dart (right):

https://codereview.chromium.org/12212016/diff/11501/tests/compiler/dart2js_ex...
tests/compiler/dart2js_extra/super_call_test.dart:7: import
"package:expect/expect.dart";
On 2013/03/10 16:19:56, Bill Hesse wrote:
> This needs to be moved up.

ah... The search/replace failed, because it didn't find the copyright-header.
done.

[floitsch, 2013-04-05 19:40:59]

Rebase and minor changes.

[floitsch, 2013-04-05 20:00:10]

Committed patchset #4 manually as r20996 (presubmit successful).