Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 12211135: Changed DO NOT EDIT disclaimer on generated DOM libraries. (Closed)

Created:
7 years, 10 months ago by Andrei Mouravski
Modified:
7 years, 10 months ago
Reviewers:
blois
CC:
reviews_dartlang.org, Kathy Walrath
Visibility:
Public.

Description

Changed DO NOT EDIT disclaimer on generated DOM libraries. This now accounts for the new docs tool. Committed: https://code.google.com/p/dart/source/detail?r=18712

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -11 lines) Patch
M sdk/lib/chrome/dart2js/chrome_dart2js.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/chrome_dart2js.darttemplate View 1 2 chunks +3 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/indexed_db_dart2js.darttemplate View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/svg_dart2js.darttemplate View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/web_audio_dart2js.darttemplate View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Andrei Mouravski
7 years, 10 months ago (2013-02-12 21:25:46 UTC) #1
blois
On 2013/02/12 21:25:46, Andrei Mouravski wrote: Can you remove that from the .darttemplate files and ...
7 years, 10 months ago (2013-02-12 23:08:56 UTC) #2
Andrei Mouravski
For the time being I want to just add this here to enable this feature, ...
7 years, 10 months ago (2013-02-14 19:15:55 UTC) #3
Andrei Mouravski
Ping. Getting the notice to allow people to modify the comments is pretty important right ...
7 years, 10 months ago (2013-02-19 17:38:13 UTC) #4
blois
7 years, 10 months ago (2013-02-19 17:45:57 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698