Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 12211099: Fixing TransitionEnd event. (Closed)

Created:
7 years, 10 months ago by blois
Modified:
7 years, 10 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing TransitionEnd event. A number of related changes- Bug 8340 is that we previously had WebKitTransitionEnd renamed to TransitionEnd, but had to remove that when Chrome added a new TransitionEnd. Changes- - Made WebKitTransitionEnd implement TransitionEnd and made it private. - Added a test for the TransitionEnd event. - Fixed the TransitionEnd event not working on non-Chrome browsers. - Added support check for CSS transitions. - Added annotations for CSS transition support. BUG=8340 Committed: https://code.google.com/p/dart/source/detail?r=18276

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -54 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 10 chunks +78 lines, -28 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 6 chunks +57 lines, -25 lines 0 comments Download
M tests/html/html.status View 1 chunk +1 line, -0 lines 0 comments Download
A tests/html/transition_event_test.dart View 1 chunk +42 lines, -0 lines 0 comments Download
M tools/dom/scripts/generator.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate View 3 chunks +42 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 2 chunks +15 lines, -0 lines 0 comments Download
A + tools/dom/templates/html/impl/impl_WebKitTransitionEvent.darttemplate View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 10 months ago (2013-02-08 19:41:43 UTC) #1
Emily Fortuna
lgtm, but I think we should move one of these files into a separate CL ...
7 years, 10 months ago (2013-02-08 20:45:17 UTC) #2
blois
7 years, 10 months ago (2013-02-08 21:05:10 UTC) #3
https://codereview.chromium.org/12211099/diff/1/tools/testing/dart/http_serve...
File tools/testing/dart/http_server.dart (right):

https://codereview.chromium.org/12211099/diff/1/tools/testing/dart/http_serve...
tools/testing/dart/http_server.dart:48:
TestingServerRunner.startHttpServer('0.0.0.0',
On 2013/02/08 20:45:17, Emily Fortuna wrote:
> Can we put this in a separate CL that has Martin or Peter or someone cc'd on?
> Also, we should add a comment explaining what 0.0.0.0 actually does for those
> who didn't take time to read the source code. Also, we should probably file a
> bug on dart IO asking them to document that! :-)

D'oh! thanks for catching. needed that for local testing!

Powered by Google App Engine
This is Rietveld 408576698