Issue 12211052: Drain HTTP request input streams before responding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12211052: Drain HTTP request input streams before responding. (Closed)

Created:
7 years, 10 months ago by Bob Nystrom

Modified:
7 years, 10 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org, Søren Gjesse

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Drain HTTP request input streams before responding. Committed: https://code.google.com/p/dart/source/detail?r=18185

Patch Set 1 #

Total comments: 2

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -8 lines)			Patch
	M	utils/pub/io.dart	View		1 chunk	+15 lines, -0 lines	0 comments	Download
	M	utils/tests/pub/pub_lish_test.dart	View		3 chunks	+14 lines, -8 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/12211052/diff/1/utils/tests/pub/pub_lish_test.dart File utils/tests/pub/pub_lish_test.dart (right): https://codereview.chromium.org/12211052/diff/1/utils/tests/pub/pub_lish_test.dart#newcode42 utils/tests/pub/pub_lish_test.dart:42: return server.url; Style nit: I'd probably make this ...

7 years, 10 months ago (2013-02-06 20:47:05 UTC) #2

Bob Nystrom

7 years, 10 months ago (2013-02-06 20:50:39 UTC) #3

Thanks!

https://codereview.chromium.org/12211052/diff/1/utils/tests/pub/pub_lish_test...
File utils/tests/pub/pub_lish_test.dart (right):

https://codereview.chromium.org/12211052/diff/1/utils/tests/pub/pub_lish_test...
utils/tests/pub/pub_lish_test.dart:42: return server.url;
On 2013/02/06 20:47:05, nweiz wrote:
> Style nit: I'd probably make this a "=>"-style lambda.

I did that first, but then the following then() doesn't have a convenient place
to go. I figured this looked marginally better than a hanging ".then()" on its
own line.

Expand Messages | Collapse Messages