Allow ambiguous Expect and ExpectException imports.

Allow ambiguous Expect and ExpectException imports.

This patch temporarily allows Expect to come from core and from any other library without (I wanted to make the CL public reporting an error (or warning).
Once everyone (including co19) has migrated I will revert this CL.

Committed: https://code.google.com/p/dart/source/detail?r=18318

[floitsch, 2013-02-06 16:30:59]

I'm trying to remove Expect from core. Tests that use Expect will have to get
Expect from somewhere else.
However, as long as "Expect" is in dart:core, if a test imports Expect through
an import it leads to an ambiguous import error.
If possible I would now do the switch in one go, but the co19 tests are not
synchronized with our repository. With this CL we allow Expect and
ExpectException to be ambiguous. This gives the co19 people a way to migrate to
a local library without having to change their class-name.
Once everyone has migrated I will revert this CL.
Before committing I will file a bug and write it next to the affected lines
(TODO(1234): remove when Except has been removed from core).

[regis, 2013-02-06 19:40:47]

LGTM

https://codereview.chromium.org/12211045/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/12211045/diff/1/runtime/vm/parser.cc#newcode8204
runtime/vm/parser.cc:8204: if (!first_lib_url.IsNull()
I would add a TODO here to remove this temporary check.

[Johnni Winther, 2013-02-07 12:01:03]

lgtm

[Johnni Winther, 2013-02-07 12:01:41]

https://codereview.chromium.org/12211045/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right):

https://codereview.chromium.org/12211045/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:603: if
(element.name == const SourceString("Expect") ||
Add a TODO.

[floitsch, 2013-02-11 17:59:32]

https://codereview.chromium.org/12211045/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/12211045/diff/1/runtime/vm/parser.cc#newcode8204
runtime/vm/parser.cc:8204: if (!first_lib_url.IsNull()
On 2013/02/06 19:40:48, regis wrote:
> I would add a TODO here to remove this temporary check.

Yes. I will add a TODO(issue-number) once I have file the issue.

https://codereview.chromium.org/12211045/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right):

https://codereview.chromium.org/12211045/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:603: if
(element.name == const SourceString("Expect") ||
On 2013/02/07 12:01:41, Johnni Winther wrote:
> Add a TODO.

Done.

[Ivan Posva, 2013-05-23 22:28:16]

What is the status of this change? Can this now finally be reverted?

Thanks,
-Ivan

[floitsch, 2013-05-24 12:20:19]

On 2013/05/23 22:28:16, Ivan Posva wrote:
> What is the status of this change? Can this now finally be reverted?
> 
> Thanks,
> -Ivan

Yes, I think so (running the tests now). Thanks for reminding.