Issue 12211004: Get most pub IO tests passing on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12211004: Get most pub IO tests passing on Windows. (Closed)

Created:
7 years, 10 months ago by Bob Nystrom

Modified:
7 years, 10 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Get most pub IO tests passing on Windows. The remaining issue now is a hang in dart:io. BUG= Committed: https://code.google.com/p/dart/source/detail?r=18112

Patch Set 1 #

Total comments: 4

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -28 lines)			Patch
M	utils/pub/io.dart	View	4 chunks	+4 lines, -1 line	2 comments	Download
M	utils/tests/pub/command_line_config.dart	View	4 chunks	+24 lines, -16 lines	2 comments	Download
M	utils/tests/pub/io_test.dart	View	4 chunks	+18 lines, -10 lines	0 comments	Download
M	utils/tests/pub/pub.status	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/12211004/diff/1/utils/pub/io.dart File utils/pub/io.dart (right): https://codereview.chromium.org/12211004/diff/1/utils/pub/io.dart#newcode183 utils/pub/io.dart:183: /// Note that on Windows, only directories may ...

7 years, 10 months ago (2013-02-05 03:26:14 UTC) #2

Bob Nystrom

7 years, 10 months ago (2013-02-05 04:21:53 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/12211004/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://codereview.chromium.org/12211004/diff/1/utils/pub/io.dart#newcode183
utils/pub/io.dart:183: /// Note that on Windows, only directories may be
symlinked to.
On 2013/02/05 03:26:14, nweiz wrote:
> Is this note supposed to be on createSymlink?

Done.

https://codereview.chromium.org/12211004/diff/1/utils/tests/pub/command_line_...
File utils/tests/pub/command_line_config.dart (right):

https://codereview.chromium.org/12211004/diff/1/utils/tests/pub/command_line_...
utils/tests/pub/command_line_config.dart:22: final _checkBox =
_getSpecial('\u2713', 'PASS');
On 2013/02/05 03:26:14, nweiz wrote:
> Style nit: "_checkbox"

Done.

Expand Messages | Collapse Messages