Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1221043003: appendHtml, when sanitizing, should create document fragment in the right context (Closed)

Created:
5 years, 5 months ago by Alan Knight
Modified:
5 years, 5 months ago
Reviewers:
terry
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : appendHtml, when sanitizing, should create document fragment in the right context #

Patch Set 3 : Don't try to use the element context for elements that don't suppor tit #

Patch Set 4 : Line length #

Patch Set 5 : Regenerated html libs after Terry's checkin #

Patch Set 6 : One more try. Suppress invalid co19 tests. Slight code cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -35 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 3 4 5 4 chunks +21 lines, -7 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 2 3 4 5 4 chunks +21 lines, -7 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 3 4 5 11 chunks +1 line, -12 lines 0 comments Download
M tests/co19/co19-dartium.status View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M tests/html/element_add_test.dart View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 2 3 4 5 4 chunks +21 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Alan Knight
https://github.com/dart-lang/sdk/issues/23737
5 years, 5 months ago (2015-07-07 20:58:43 UTC) #2
terry
lgtm
5 years, 5 months ago (2015-07-08 16:57:54 UTC) #3
Alan Knight
Committed patchset #2 (id:20001) manually as 560f12bb21874824788e1f660ca07b8914c8cc4f (presubmit successful).
5 years, 5 months ago (2015-07-08 17:16:41 UTC) #4
Alan Knight
Fixed the bot errors, PTAL.
5 years, 5 months ago (2015-07-10 20:34:57 UTC) #5
terry
lgtm
5 years, 5 months ago (2015-07-13 14:38:11 UTC) #6
Alan Knight
Committed patchset #5 (id:80001) manually as 930a40daa50a93adfce8786f4d7ef25e06324dda (presubmit successful).
5 years, 5 months ago (2015-07-13 19:50:54 UTC) #7
Alan Knight
Also removed code that was a workaround for a Chrome bug fixed in Feb 2014. ...
5 years, 5 months ago (2015-07-14 18:12:03 UTC) #8
Alan Knight
5 years, 5 months ago (2015-07-16 17:30:57 UTC) #9
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as
4e790fef3d01aed11bdf470be37a506813565d98 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698