Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1221033008: Revert usage of delegating generative constructor, still not supported by VM. (Closed)

Created:
5 years, 5 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 5 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert usage of delegating generative constructor, still not supported by VM. Also update test expectation for d8/jsshell now that test doesn't use non-zero timer any more. R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/03f92623b25574494eac972e5a9255e9e3819462

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M sdk/lib/async/stream.dart View 1 chunk +4 lines, -1 line 0 comments Download
M tests/lib/lib.status View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lasse Reichstein Nielsen
TBR
5 years, 5 months ago (2015-07-03 12:49:14 UTC) #2
Søren Gjesse
lgtm
5 years, 5 months ago (2015-07-03 12:51:06 UTC) #3
Lasse Reichstein Nielsen
5 years, 5 months ago (2015-07-03 12:53:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
03f92623b25574494eac972e5a9255e9e3819462 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698