Add substitution for classes that use type variables.

Add substitution for classes that use type variables.

Committed: https://code.google.com/p/dart/source/detail?r=18379

[kasperl, 2013-02-12 12:14:10]

LGTM.

https://codereview.chromium.org/12210138/diff/3001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/12210138/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3185: // The type
variable is stored on the object.
Extend the comment with an example of the kind of code this unfolds to?

https://codereview.chromium.org/12210138/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3188: String
substituionNameString =
substituion -> substitution

https://codereview.chromium.org/12210138/diff/3001/tests/language/generic_cre...
File tests/language/generic_creation_test.dart (right):

https://codereview.chromium.org/12210138/diff/3001/tests/language/generic_cre...
tests/language/generic_creation_test.dart:13: class B extends A<U, V, W> {}
Could you also test that something like:

  class C<T> extends A<U, T, W> {}

would be testable like this:

  C c = new C<V>();
  sameType(new A<A<U, U, U>, A<V, V, V>, A<W, W, W>>(), c.wrap());

[karlklose, 2013-02-12 13:22:30]

Thanks, Kasper.

https://codereview.chromium.org/12210138/diff/3001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/12210138/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3185: // The type
variable is stored on the object.
On 2013/02/12 12:14:10, kasperl wrote:
> Extend the comment with an example of the kind of code this unfolds to?

Done.

https://codereview.chromium.org/12210138/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3188: String
substituionNameString =
On 2013/02/12 12:14:10, kasperl wrote:
> substituion -> substitution

Done.

https://codereview.chromium.org/12210138/diff/3001/tests/language/generic_cre...
File tests/language/generic_creation_test.dart (right):

https://codereview.chromium.org/12210138/diff/3001/tests/language/generic_cre...
tests/language/generic_creation_test.dart:13: class B extends A<U, V, W> {}
On 2013/02/12 12:14:10, kasperl wrote:
> Could you also test that something like:
> 
>   class C<T> extends A<U, T, W> {}
> 
> would be testable like this:
> 
>   C c = new C<V>();
>   sameType(new A<A<U, U, U>, A<V, V, V>, A<W, W, W>>(), c.wrap());

Done.

[ngeoffray, 2013-02-12 21:56:15]

DBC

https://codereview.chromium.org/12210138/diff/8001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right):

https://codereview.chromium.org/12210138/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1285: for
(ClassElement check in checkedClasses) {
Any reason why you changed the order of the loops between the two versions?

https://codereview.chromium.org/12210138/diff/8001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/12210138/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3195: new
LiteralDartString(substitutionNameString), null, constantSystem);
line too long