Issue 12210098: Fix a couple ScheduleError error messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12210098: Fix a couple ScheduleError error messages. (Closed)

Created:
7 years, 10 months ago by nweiz

Modified:
7 years, 10 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix a couple ScheduleError error messages. Committed: https://code.google.com/p/dart/source/detail?r=18350

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	pkg/scheduled_test/lib/src/schedule_error.dart	View	1	3 chunks	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

7 years, 10 months ago (2013-02-11 22:30:19 UTC) #2

Couple of nits, then LGTM.

https://codereview.chromium.org/12210098/diff/1/pkg/scheduled_test/lib/src/sc...
File pkg/scheduled_test/lib/src/schedule_error.dart (right):

https://codereview.chromium.org/12210098/diff/1/pkg/scheduled_test/lib/src/sc...
pkg/scheduled_test/lib/src/schedule_error.dart:47: : super.withCause(error,
stackTrace, cause) {
Indent another two.

https://codereview.chromium.org/12210098/diff/1/pkg/scheduled_test/lib/src/sc...
pkg/scheduled_test/lib/src/schedule_error.dart:48: _scheduleWasDone =
schedule.done;
I'd prefer this to be final and in the initialization list. You'll have to make
schedule not use "this." and manually initialize it too, but I like making
things final whenever possible.

Expand Messages | Collapse Messages