Issue 12210073: Re-submit of 12213058 to fix CharacterData.remove

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12210073: Re-submit of 12213058 to fix CharacterData.remove (Closed)

Created:
7 years, 10 months ago by blois

Modified:
7 years, 10 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Re-submit of 12213058 to fix CharacterData.remove Original was hanging on Dartium as it was missing useHtmlConfiguration in the test. patch from issue 12213058 BUG= Committed: https://code.google.com/p/dart/source/detail?r=18237

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -8 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download
A	tests/html/cdata_test.dart	View	1 chunk	+24 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages