Issue 1220913002: Fix a test crash with Dart 1.12.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1220913002: Fix a test crash with Dart 1.12. (Closed)

Created:
5 years, 5 months ago by nweiz

Modified:
5 years, 5 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix a test crash with Dart 1.12. If the tests were run with an absolute URL passed as --package-root (as is true for `pub run` in 1.12), it would try to treat it as a path and crash. Now it converts it from a URL before doing any path manipulation. Closes #281 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/68db83e01911653037dd1edc6607b40f5ccd3d53

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	test/io.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

nweiz

5 years, 5 months ago (2015-06-30 20:16:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
68db83e01911653037dd1edc6607b40f5ccd3d53 (presubmit successful).