Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 12209073: Add a scheduled test library. (Closed)

Created:
7 years, 10 months ago by nweiz
Modified:
7 years, 9 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a scheduled test library. Committed: https://code.google.com/p/dart/source/detail?r=18285

Patch Set 1 #

Patch Set 2 : Make everything play nicely with the outside world. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1581 lines, -0 lines) Patch
M pkg/pkg.status View 1 1 chunk +3 lines, -0 lines 2 comments Download
A pkg/scheduled_test/lib/scheduled_test.dart View 1 chunk +292 lines, -0 lines 0 comments Download
A pkg/scheduled_test/lib/src/schedule.dart View 1 chunk +248 lines, -0 lines 0 comments Download
A pkg/scheduled_test/lib/src/schedule_error.dart View 1 chunk +72 lines, -0 lines 0 comments Download
A pkg/scheduled_test/lib/src/task.dart View 1 chunk +51 lines, -0 lines 0 comments Download
A pkg/scheduled_test/lib/src/utils.dart View 1 chunk +53 lines, -0 lines 0 comments Download
A pkg/scheduled_test/pubspec.yaml View 1 chunk +13 lines, -0 lines 0 comments Download
A pkg/scheduled_test/test/metatest.dart View 1 1 chunk +204 lines, -0 lines 0 comments Download
A pkg/scheduled_test/test/scheduled_test_test.dart View 1 chunk +644 lines, -0 lines 0 comments Download
M utils/apidoc/apidoc.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ricow1
Why no reviewers of this code? https://codereview.chromium.org/12209073/diff/1009/pkg/pkg.status File pkg/pkg.status (right): https://codereview.chromium.org/12209073/diff/1009/pkg/pkg.status#newcode13 pkg/pkg.status:13: scheduled_test/lib/*: Skip I ...
7 years, 9 months ago (2013-03-18 11:34:53 UTC) #1
nweiz
7 years, 9 months ago (2013-03-18 18:37:55 UTC) #2
Message was sent while issue was closed.
The review was conducted at https://codereview.chromium.org/12208081/; I don't
know where this issue came from.

https://codereview.chromium.org/12209073/diff/1009/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/12209073/diff/1009/pkg/pkg.status#newcode13
pkg/pkg.status:13: scheduled_test/lib/*: Skip
On 2013/03/18 11:34:53, ricow1 wrote:
> I don't get this, why do we call it _test if it is not a test?

It's a library for writing tests.

Powered by Google App Engine
This is Rietveld 408576698