Issue 12209057: Optimize branches in polymorphic equality operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12209057: Optimize branches in polymorphic equality operations. (Closed)

Created:
7 years, 10 months ago by Florian Schneider

Modified:
7 years, 10 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Optimize branches in polymorphic equality operations. Committed: https://code.google.com/p/dart/source/detail?r=18256

Patch Set 3 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -12 lines)			Patch
	M	runtime/vm/intermediate_language_ia32.cc	View	1 2	3 chunks	+9 lines, -6 lines	0 comments	Download
	M	runtime/vm/intermediate_language_x64.cc	View	1 2	3 chunks	+9 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

lgtm https://codereview.chromium.org/12209057/diff/2001/runtime/vm/intermediate_language_ia32.cc File runtime/vm/intermediate_language_ia32.cc (right): https://codereview.chromium.org/12209057/diff/2001/runtime/vm/intermediate_language_ia32.cc#newcode516 runtime/vm/intermediate_language_ia32.cc:516: __ Bind(&next_test); This can go inside the if, ...

7 years, 10 months ago (2013-02-08 14:21:29 UTC) #2

Florian Schneider

7 years, 10 months ago (2013-02-08 15:30:28 UTC) #3

Thanks.

https://codereview.chromium.org/12209057/diff/2001/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/12209057/diff/2001/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_ia32.cc:516: __ Bind(&next_test);
On 2013/02/08 14:21:29, kmillikin wrote:
> This can go inside the if, no?  That might be clearer.

Yes, it can. Done.

Expand Messages | Collapse Messages

Issue 12209057: Optimize branches in polymorphic equality operations. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages