Issue 12209047: Added Socket::Close() function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12209047: Added Socket::Close() function. (Closed)

Created:
7 years, 10 months ago by Tom Ball

Modified:
7 years, 10 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -1 line)			Patch
M	runtime/bin/dbg_connection.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/socket.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/socket_android.cc	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	runtime/bin/socket_linux.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	runtime/bin/socket_macos.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	runtime/bin/socket_win.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Tom Ball

Needed by vmstats, plus there is a debugger TODO about adding a socket close.

7 years, 10 months ago (2013-02-06 23:43:36 UTC) #1

hausner

7 years, 10 months ago (2013-02-06 23:58:43 UTC) #2

LGTM.

This allows http://code.google.com/p/dart/issues/detail?id=3797 to be fixed :)