Initial commit of generated dart:chrome app_window and app_runtime

Initial commit of generated dart:chrome app_window and app_runtime

Contains a working version of app_window.idl and app_runtime.idl, and can be run by importing the dart:chrome library.

Build with JSON Schema Compiler from Chromium.

Committed: https://code.google.com/p/dart/source/detail?r=18415

[sashab, 2013-02-06 22:55:49]

Hi all,

This patch contains generated code for app_window.idl and app_runtime.idl. It
was generated with a version of JSON Schema Compiler that is still under review.

Please take a look at the generated output. I have created a sample chrome app
and managed to use the APIs for opening windows, in both the background page and
main App page.

The code in custom_dart/ was used for overrides.

[blois, 2013-02-08 00:08:04]

https://codereview.chromium.org/12209045/diff/3001/tools/dom/scripts/chromege...
File tools/dom/scripts/chromegenerator.py (right):

https://codereview.chromium.org/12209045/diff/3001/tools/dom/scripts/chromege...
tools/dom/scripts/chromegenerator.py:11: # The path to the JSON Schema Compiler,
which can be run to generate the files.
This library structure was set up when we thought you'd be able to use more of
the dom scripts, but obviously not now.

Not as this CL, but in a future one this and the other dart:chrome files should
be moved into tools/chrome rather than tools/dom.

https://codereview.chromium.org/12209045/diff/3001/tools/dom/src/chrome/app_w...
File tools/dom/src/chrome/app_window.dart (right):

https://codereview.chromium.org/12209045/diff/3001/tools/dom/src/chrome/app_w...
tools/dom/src/chrome/app_window.dart:171: /// X coordinate of the window.
(Deprecated; use 'bounds'.)
These were here before, but is it possible to remove the deprecated APIs? We're
starting with a clean slate.

https://codereview.chromium.org/12209045/diff/3001/tools/dom/src/chrome/custo...
File tools/dom/src/chrome/custom_dart/app_window.AppWindow.contentWindow.dart
(right):

https://codereview.chromium.org/12209045/diff/3001/tools/dom/src/chrome/custo...
tools/dom/src/chrome/custom_dart/app_window.AppWindow.contentWindow.dart:1: //
TODO(sashab, sra): Detect whether this is the current window, or an
should have a copyright notice

https://codereview.chromium.org/12209045/diff/3001/tools/dom/templates/html/d...
File tools/dom/templates/html/dart2js/chrome_dart2js.darttemplate (right):

https://codereview.chromium.org/12209045/diff/3001/tools/dom/templates/html/d...
tools/dom/templates/html/dart2js/chrome_dart2js.darttemplate:6: //
Auto-generated dart:chrome library.
Would be great to add a dartdoc comment in here, just a brief explanation of the
library.

If you do it preceding the library declaration then it will show up as a library
comment.

https://codereview.chromium.org/12209045/diff/3001/tools/dom/templates/html/d...
tools/dom/templates/html/dart2js/chrome_dart2js.darttemplate:11: /*
TODO(sashab): Add "show convertDartClosureToJS" once 'show' works. */
Is this file still being used?

[benwells, 2013-02-08 00:17:46]

https://codereview.chromium.org/12209045/diff/3001/tools/dom/src/chrome/app_w...
File tools/dom/src/chrome/app_window.dart (right):

https://codereview.chromium.org/12209045/diff/3001/tools/dom/src/chrome/app_w...
tools/dom/src/chrome/app_window.dart:171: /// X coordinate of the window.
(Deprecated; use 'bounds'.)
On 2013/02/08 00:08:04, blois wrote:
> These were here before, but is it possible to remove the deprecated APIs?
We're
> starting with a clean slate.

We have no way of automatically ignoring deprecated things. We could assume if
the comment has the word 'deprecated' somewhere it is deprecated, but that would
be fragile - I can imaging a comment saying 'Use this instead of foo, as foo is
deprecated;.

An alternative would be to manually override all of these.

[sashab, 2013-02-08 00:49:28]

Added licenses to the override files, and updated the generator to produce
slightly better formatted code.

Also added a description to the library in the template file.

https://codereview.chromium.org/12209045/diff/3001/tools/dom/scripts/chromege...
File tools/dom/scripts/chromegenerator.py (right):

https://codereview.chromium.org/12209045/diff/3001/tools/dom/scripts/chromege...
tools/dom/scripts/chromegenerator.py:11: # The path to the JSON Schema Compiler,
which can be run to generate the files.
On 2013/02/08 00:08:04, blois wrote:
> This library structure was set up when we thought you'd be able to use more of
> the dom scripts, but obviously not now.
> 
> Not as this CL, but in a future one this and the other dart:chrome files
should
> be moved into tools/chrome rather than tools/dom.

Agreed :)

https://codereview.chromium.org/12209045/diff/3001/tools/dom/src/chrome/custo...
File tools/dom/src/chrome/custom_dart/app_window.AppWindow.contentWindow.dart
(right):

https://codereview.chromium.org/12209045/diff/3001/tools/dom/src/chrome/custo...
tools/dom/src/chrome/custom_dart/app_window.AppWindow.contentWindow.dart:1: //
TODO(sashab, sra): Detect whether this is the current window, or an
On 2013/02/08 00:08:04, blois wrote:
> should have a copyright notice

Done.

https://codereview.chromium.org/12209045/diff/3001/tools/dom/templates/html/d...
File tools/dom/templates/html/dart2js/chrome_dart2js.darttemplate (right):

https://codereview.chromium.org/12209045/diff/3001/tools/dom/templates/html/d...
tools/dom/templates/html/dart2js/chrome_dart2js.darttemplate:6: //
Auto-generated dart:chrome library.
On 2013/02/08 00:08:04, blois wrote:
> Would be great to add a dartdoc comment in here, just a brief explanation of
the
> library.
> 
> If you do it preceding the library declaration then it will show up as a
library
> comment.

Done.

https://codereview.chromium.org/12209045/diff/3001/tools/dom/templates/html/d...
tools/dom/templates/html/dart2js/chrome_dart2js.darttemplate:11: /*
TODO(sashab): Add "show convertDartClosureToJS" once 'show' works. */
On 2013/02/08 00:08:04, blois wrote:
> Is this file still being used?

Doesn't it _have_ to be used? My impression was that go.sh generates a library
from a template, so this template is needed for the build process.

If it doesn't have to be used, we can scrap it and I can put all the imports in
src/chrome.dart

[sashab, 2013-02-08 01:43:57]

Added prefixes to type names in the generated library, e.g. Bounds -->
AppWindowBounds, etc.

This is needed as Dart does not currently support nested types, and, in the IDL,
these typenames are not guaranteed to be unique across all files.

One possible solution to this might be to implement this library as multiple
files, allowing users to import only the part of the library that they need
(e.g. import dart:chrome/app_runtime, dart:chrome/app_window, etc).

Not sure if this is possible with the import statement for standard libraries,
or with the SDK build process. Thoughts?

[blois, 2013-02-12 17:25:39]

lgtm

I think the current naming approach is sufficient- agree that it's not exactly
elegant though.