Issue 12208109: Remove erroneous assert from Windows implementation of dart:io File.fullPath.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12208109: Remove erroneous assert from Windows implementation of dart:io File.fullPath. (Closed)

Created:
7 years, 10 months ago by Bill Hesse

Modified:
7 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Google), Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove erroneous assert from Windows implementation of dart:io File.fullPath. BUG= Committed: https://code.google.com/p/dart/source/detail?r=18307

Patch Set 2 : Add fix of broken directory_test test. #

Patch Set 3 : underscores, not dashes #

Total comments: 2

Patch Set 4 : address comments #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -64 lines)			Patch
	M	runtime/bin/file_win.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/standalone/io/directory_test.dart	View	1 2	4 chunks	+19 lines, -63 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://codereview.chromium.org/12208109/diff/4001/runtime/bin/file_win.cc File runtime/bin/file_win.cc (left): https://codereview.chromium.org/12208109/diff/4001/runtime/bin/file_win.cc#oldcode212 runtime/bin/file_win.cc:212: ASSERT(written == (required_size - 1)); you can assert ...

7 years, 10 months ago (2013-02-11 13:42:12 UTC) #5

Anders Johnsen

7 years, 6 months ago (2013-06-11 12:23:37 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/12208109/diff/4001/runtime/bin/file_win.cc
File runtime/bin/file_win.cc (left):

https://codereview.chromium.org/12208109/diff/4001/runtime/bin/file_win.cc#ol...
runtime/bin/file_win.cc:212: ASSERT(written == (required_size - 1));
On 2013/02/11 13:42:12, Vyacheslav Egorov (Google) wrote:
> you can assert written < required_size

Good idea!