Getter and setter methods can share name.

Getter and setter methods can share name.


R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=18306

[Brian Wilkerson, 2013-02-10 18:41:42]

The changes to java2dart LGTM, but I suspect that the changes to

  compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

were not intended to be part of this CL. If that's wrong, please explain how
they are relevant.

[scheglov, 2013-02-10 20:33:52]

On 2013/02/10 18:41:42, Brian Wilkerson wrote:
> The changes to java2dart LGTM, but I suspect that the changes to
> 
>   compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java
> 
> were not intended to be part of this CL. If that's wrong, please explain how
> they are relevant.

  Problem is that after translating AE to Dart Editor starts to show problems.
  Reason is that when you have 
class EA {}
class EAImpl implements EA {}
class EB {}
class EBImpl implements EB {}

and then
class A {
  EA get element;
  void set element(EAImpl v);
}

class B extends A {
  EB get element;
}

...then dartc thinks that type of field A.element is AEImpl. So, it shows
warning that B.element has type EB, which is not subclass of AEImpl. So, I have
to fix dartc simultaneously with java2dart to avoid confusion for
analyzer-experimental users.

[Brian Wilkerson, 2013-02-10 22:04:49]

> ...then dartc thinks that type of field A.element is AEImpl. So, it shows
> warning that B.element has type EB, which is not subclass of AEImpl. So, I
have
> to fix dartc simultaneously with java2dart to avoid confusion for
> analyzer-experimental users.

I'm still missing something. It seems to me that dartc should think that the
type of the field A.element is EA, and when it finds B.element to have a type of
EB, which is not a subclass of EA, it should report an error. So the details of
the error are wrong, but the error is not.

[scheglov, 2013-02-10 22:22:29]

On 2013/02/10 22:04:49, Brian Wilkerson wrote:
> > ...then dartc thinks that type of field A.element is AEImpl. So, it shows
> > warning that B.element has type EB, which is not subclass of AEImpl. So, I
> have
> > to fix dartc simultaneously with java2dart to avoid confusion for
> > analyzer-experimental users.
> 
> I'm still missing something. It seems to me that dartc should think that the
> type of the field A.element is EA, and when it finds B.element to have a type
of
> EB, which is not a subclass of EA, it should report an error. So the details
of
> the error are wrong, but the error is not.

  Ah... Yes, I've missed this.
class EB extends EA {}
class EBImpl extends EAImpl implements EB {}

[Brian Wilkerson, 2013-02-10 22:47:41]

Ah. In that case, LGTM.