Issue 12208096: Make the scheduled_test schedule keep track of multiple errors.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+158 lines, -43 lines)			Patch
M	pkg/scheduled_test/lib/scheduled_test.dart	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/scheduled_test/lib/src/schedule.dart	View	1 2 3 4	8 chunks	+53 lines, -14 lines	0 comments	Download
M	pkg/scheduled_test/test/scheduled_test_test.dart	View	1 2	2 chunks	+102 lines, -26 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

I'd like some clarification. Otherwise LGTM. https://codereview.chromium.org/12208096/diff/5001/pkg/scheduled_test/lib/src/schedule.dart File pkg/scheduled_test/lib/src/schedule.dart (right): https://codereview.chromium.org/12208096/diff/5001/pkg/scheduled_test/lib/src/schedule.dart#newcode75 pkg/scheduled_test/lib/src/schedule.dart:75: final List<ScheduleError> errors ...

7 years, 10 months ago (2013-02-11 22:28:38 UTC) #2

nweiz

7 years, 10 months ago (2013-02-11 22:52:20 UTC) #3

https://codereview.chromium.org/12208096/diff/5001/pkg/scheduled_test/lib/src...
File pkg/scheduled_test/lib/src/schedule.dart (right):

https://codereview.chromium.org/12208096/diff/5001/pkg/scheduled_test/lib/src...
pkg/scheduled_test/lib/src/schedule.dart:75: final List<ScheduleError> errors =
<ScheduleError>[];
On 2013/02/11 22:28:38, Bob Nystrom wrote:
> You can probably drop the type annotation here:
> 
> final errors = ...

Done.

https://codereview.chromium.org/12208096/diff/5001/pkg/scheduled_test/lib/src...
pkg/scheduled_test/lib/src/schedule.dart:116: throw e;
On 2013/02/11 22:28:38, Bob Nystrom wrote:
> Is the intent here that the Future returned from run() completes to the first
> error if an error occurred? The rethrows are a bit confusing. Can you document
> what they're for? 

Done.

Expand Messages | Collapse Messages

Issue 12208096: Make the scheduled_test schedule keep track of multiple errors. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Remove a TODO. #

Patch Set 3 : Fix a loophole #

Patch Set 4 : Fix out-of-band unwrapped error reporting. #

Patch Set 5 : Code review changes #

Messages