Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 1220713008: Fixes to the service.md doc. Various minor changes discovered while (Closed)

Created:
5 years, 5 months ago by devoncarew
Modified:
5 years, 5 months ago
Reviewers:
turnidge, Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixes to the service.md doc. Various minor changes discovered while parsing the file. BUG= R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/969d882e6e83cb8ee2f6adba79a8331b9ab21291

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
M runtime/vm/service/service.md View 1 11 chunks +14 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
devoncarew
https://codereview.chromium.org/1220713008/diff/1/runtime/vm/service/service.md File runtime/vm/service/service.md (left): https://codereview.chromium.org/1220713008/diff/1/runtime/vm/service/service.md#oldcode1185 runtime/vm/service/service.md:1185: // A Dart language function. Already doc'd below, and ...
5 years, 5 months ago (2015-06-29 18:38:20 UTC) #2
turnidge
lgtm w/ 1 comment. https://codereview.chromium.org/1220713008/diff/1/runtime/vm/service/service.md File runtime/vm/service/service.md (left): https://codereview.chromium.org/1220713008/diff/1/runtime/vm/service/service.md#oldcode1185 runtime/vm/service/service.md:1185: // A Dart language function. ...
5 years, 5 months ago (2015-06-29 22:07:01 UTC) #3
devoncarew
https://codereview.chromium.org/1220713008/diff/1/runtime/vm/service/service.md File runtime/vm/service/service.md (right): https://codereview.chromium.org/1220713008/diff/1/runtime/vm/service/service.md#newcode839 runtime/vm/service/service.md:839: class Code extends @Object { On 2015/06/29 22:07:01, turnidge ...
5 years, 5 months ago (2015-06-29 22:22:22 UTC) #4
turnidge
https://codereview.chromium.org/1220713008/diff/1/runtime/vm/service/service.md File runtime/vm/service/service.md (right): https://codereview.chromium.org/1220713008/diff/1/runtime/vm/service/service.md#newcode839 runtime/vm/service/service.md:839: class Code extends @Object { On 2015/06/29 22:22:22, devoncarew ...
5 years, 5 months ago (2015-06-29 22:55:36 UTC) #5
devoncarew
5 years, 5 months ago (2015-06-30 02:57:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
969d882e6e83cb8ee2f6adba79a8331b9ab21291 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698