Issue 12207117: SSE Assembler and Disassembler support

Issue 12207117: SSE Assembler and Disassembler support (Closed)

Created:
7 years, 10 months ago by Cutch

Modified:
7 years, 10 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

SSE Assembler and Disassembler support Committed: https://code.google.com/p/dart/source/detail?r=18406

Patch Set 3 : Review fixes #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1453 lines, -19 lines)			Patch
M	runtime/platform/globals.h	View		2 chunks	+34 lines, -1 line	0 comments	Download
M	runtime/vm/assembler_ia32.h	View		3 chunks	+31 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_ia32.cc	View		6 chunks	+251 lines, -6 lines	0 comments	Download
M	runtime/vm/assembler_ia32_test.cc	View	1	1 chunk	+372 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_x64.h	View		2 chunks	+33 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View		7 chunks	+290 lines, -6 lines	0 comments	Download
M	runtime/vm/assembler_x64_test.cc	View	1	1 chunk	+324 lines, -0 lines	0 comments	Download
M	runtime/vm/disassembler_ia32.cc	View		4 chunks	+72 lines, -0 lines	0 comments	Download
M	runtime/vm/disassembler_x64.cc	View	1 2	3 chunks	+46 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM with comments. https://codereview.chromium.org/12207117/diff/2001/runtime/platform/globals.h File runtime/platform/globals.h (right): https://codereview.chromium.org/12207117/diff/2001/runtime/platform/globals.h#newcode82 runtime/platform/globals.h:82: #include <xmmintrin.h> // NOLINT Make sure ...

7 years, 10 months ago (2013-02-12 19:06:35 UTC) #2

Cutch

7 years, 10 months ago (2013-02-12 22:34:27 UTC) #4

https://codereview.chromium.org/12207117/diff/2001/runtime/platform/globals.h
File runtime/platform/globals.h (right):

https://codereview.chromium.org/12207117/diff/2001/runtime/platform/globals.h...
runtime/platform/globals.h:82: #include <xmmintrin.h>  // NOLINT
I can build both simmips and simarm without issue.

https://codereview.chromium.org/12207117/diff/2001/runtime/vm/disassembler_x6...
File runtime/vm/disassembler_x64.cc (right):

https://codereview.chromium.org/12207117/diff/2001/runtime/vm/disassembler_x6...
runtime/vm/disassembler_x64.cc:1436: break;
Cleaned up.

Expand Messages | Collapse Messages