Issue 12207038: Fix issue http://dartbug.com/8350 by dealing with interceptors in invokeOn.

Issue 12207038: Fix issue http://dartbug.com/8350 by dealing with interceptors in invokeOn. (Closed)

Created:
7 years, 10 months ago by kasperl

Modified:
7 years, 10 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix issue http://dartbug.com/8350 by dealing with interceptors in invokeOn. R=ngeoffray@google.com BUG=http://dartbug.com/8350 Committed: https://code.google.com/p/dart/source/detail?r=18168

Patch Set 1 #

Total comments: 3

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+92 lines, -5 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/lib/interceptors.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_helper.dart	View	2 chunks	+13 lines, -4 lines	0 comments	Download
A	tests/language/invocation_mirror_invoke_on2_test.dart	View	1 chunk	+78 lines, -0 lines	3 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! https://codereview.chromium.org/12207038/diff/1/tests/language/invocation_mirror_invoke_on2_test.dart File tests/language/invocation_mirror_invoke_on2_test.dart (right): https://codereview.chromium.org/12207038/diff/1/tests/language/invocation_mirror_invoke_on2_test.dart#newcode15 tests/language/invocation_mirror_invoke_on2_test.dart:15: testDouble(); If you want to be exhaustive, you ...

7 years, 10 months ago (2013-02-06 12:40:38 UTC) #2

kasperl

https://codereview.chromium.org/12207038/diff/1/tests/language/invocation_mirror_invoke_on2_test.dart File tests/language/invocation_mirror_invoke_on2_test.dart (right): https://codereview.chromium.org/12207038/diff/1/tests/language/invocation_mirror_invoke_on2_test.dart#newcode15 tests/language/invocation_mirror_invoke_on2_test.dart:15: testDouble(); On 2013/02/06 12:40:39, ngeoffray wrote: > If you ...

7 years, 10 months ago (2013-02-06 12:46:14 UTC) #3

ngeoffray

7 years, 10 months ago (2013-02-06 12:50:31 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/12207038/diff/1/tests/language/invocation_mir...
File tests/language/invocation_mirror_invoke_on2_test.dart (right):

https://codereview.chromium.org/12207038/diff/1/tests/language/invocation_mir...
tests/language/invocation_mirror_invoke_on2_test.dart:15: testDouble();
On 2013/02/06 12:46:14, kasperl wrote:
> On 2013/02/06 12:40:39, ngeoffray wrote:
> > If you want to be exhaustive, you can also check null, bool and static
> functions
> > (that become JS functions).
> 
> Yeah, but none of those objects have any methods I can call through the proxy
> which makes them a little bit less interesting to test.

Good point :)

Expand Messages | Collapse Messages