Issue 12207028: Save 0.00001% memory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12207028: Save 0.00001% memory (Closed)

Created:
7 years, 10 months ago by hausner

Modified:
7 years, 10 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Save 0.00001% memory Release the functions and fields array after patching classes. Committed: https://code.google.com/p/dart/source/detail?r=18158

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	runtime/vm/object.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Ivan Posva

7 years, 10 months ago (2013-02-05 22:38:51 UTC) #2

It is not just the memory savings. It is the fact that the patch class should
not have any observable behaviour associated with it.

LGTM

-Ivan