Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issue 12207017: Allow metadata on script tags. (Closed)

Created:
7 years, 10 months ago by ahe
Modified:
7 years, 10 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, kasperl
Visibility:
Public.

Description

Allow metadata on script tags. Committed: https://code.google.com/p/dart/source/detail?r=18136

Patch Set 1 : #

Patch Set 2 : Fix bug in legacy tags #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -23 lines) Patch
M dart/sdk/lib/_internal/compiler/implementation/patch_parser.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart View 6 chunks +28 lines, -6 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/scanner/parser.dart View 1 chunk +1 line, -0 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/tree/nodes.dart View 1 8 chunks +28 lines, -11 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/tree/tree.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M dart/tests/compiler/dart2js/metadata_test.dart View 2 chunks +68 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ahe
If it isn't obvious, this is need for deferred/lazy loading of libraries.
7 years, 10 months ago (2013-02-05 12:48:43 UTC) #1
Johnni Winther
lgtm
7 years, 10 months ago (2013-02-05 12:59:00 UTC) #2
ahe
7 years, 10 months ago (2013-02-05 13:30:11 UTC) #3
Message was sent while issue was closed.
Minor tweak before submitting to avoid crash in co19 test and silence
dart_analyzer.

Powered by Google App Engine
This is Rietveld 408576698