Move source maps package to the dart repo, so it can be used by other internal

Move source maps package to the dart repo, so it can be used by other internal
tools.

Committed: https://code.google.com/p/dart/source/detail?r=20300

[Siggi Cherem (dart-lang), 2013-02-05 05:12:59]

This CL is a simple code move: the same code was reviewed before in our external
repo (here: https://github.com/dart-lang/source-maps/)

The only thing that changed (besides the obvious move) is that the pubspec no
longer has a version number, so it can be assigned automatically when we upload
it from trunk.

Dan/Bob - are there any other requirements to make this a pkg package? Will this
be published in pub by the upload script on the next release or do we need to
add this to some list somewhere?

Peter - I hope this will be helpful for you =). Please coordinate with me if
you'd like to make improvements. The API with spans and locations is actually
quite important as this will be used by several of our other tools (html5lib,
web-ui, etc).

[Jennifer Messerly, 2013-02-05 05:22:08]

On 2013/02/05 05:12:59, Siggi Cherem (dart-lang) wrote:
> This CL is a simple code move: the same code was reviewed before in our
external
> repo (here: https://github.com/dart-lang/source-maps/)
> 
> The only thing that changed (besides the obvious move) is that the pubspec no
> longer has a version number, so it can be assigned automatically when we
upload
> it from trunk.
> 
> Dan/Bob - are there any other requirements to make this a pkg package? Will
this
> be published in pub by the upload script on the next release or do we need to
> add this to some list somewhere?
> 
> Peter - I hope this will be helpful for you =). Please coordinate with me if
> you'd like to make improvements. The API with spans and locations is actually
> quite important as this will be used by several of our other tools (html5lib,
> web-ui, etc).

The only one I know is
    tools/create_sdk.py

It's used for package import rewriting magic. Search in there for "yaml",
there's a list you need to have your package be in. Dan also has
tools/publish_all_pkgs.py, but it uses a blacklist instead of a whitelist, so
you should be good without needing changes to that script.

[Siggi Cherem (dart-lang), 2013-02-05 05:34:25]

On 2013/02/05 05:22:08, John Messerly wrote:
> On 2013/02/05 05:12:59, Siggi Cherem (dart-lang) wrote:
> > This CL is a simple code move: the same code was reviewed before in our
> external
> > repo (here: https://github.com/dart-lang/source-maps/)
> > 
> > The only thing that changed (besides the obvious move) is that the pubspec
no
> > longer has a version number, so it can be assigned automatically when we
> upload
> > it from trunk.
> > 
> > Dan/Bob - are there any other requirements to make this a pkg package? Will
> this
> > be published in pub by the upload script on the next release or do we need
to
> > add this to some list somewhere?
> > 
> > Peter - I hope this will be helpful for you =). Please coordinate with me if
> > you'd like to make improvements. The API with spans and locations is
actually
> > quite important as this will be used by several of our other tools
(html5lib,
> > web-ui, etc).
> 
> The only one I know is
>     tools/create_sdk.py
> 
> It's used for package import rewriting magic. Search in there for "yaml",
> there's a list you need to have your package be in. Dan also has
> tools/publish_all_pkgs.py, but it uses a blacklist instead of a whitelist, so
> you should be good without needing changes to that script.

Thanks John - I was thinking that we probably just want this package to be in
pub, but not to be shipped with the SDK. So maybe I won't need to add it to
create_sdk either. Similar to how today we push the 'browser' package.

[dgrove, 2013-02-05 05:35:28]

On 2013/02/05 05:34:25, Siggi Cherem (dart-lang) wrote:
> On 2013/02/05 05:22:08, John Messerly wrote:
> > On 2013/02/05 05:12:59, Siggi Cherem (dart-lang) wrote:
> > > This CL is a simple code move: the same code was reviewed before in our
> > external
> > > repo (here: https://github.com/dart-lang/source-maps/)
> > > 
> > > The only thing that changed (besides the obvious move) is that the pubspec
> no
> > > longer has a version number, so it can be assigned automatically when we
> > upload
> > > it from trunk.
> > > 
> > > Dan/Bob - are there any other requirements to make this a pkg package?
Will
> > this
> > > be published in pub by the upload script on the next release or do we need
> to
> > > add this to some list somewhere?
> > > 
> > > Peter - I hope this will be helpful for you =). Please coordinate with me
if
> > > you'd like to make improvements. The API with spans and locations is
> actually
> > > quite important as this will be used by several of our other tools
> (html5lib,
> > > web-ui, etc).
> > 
> > The only one I know is
> >     tools/create_sdk.py
> > 
> > It's used for package import rewriting magic. Search in there for "yaml",
> > there's a list you need to have your package be in. Dan also has
> > tools/publish_all_pkgs.py, but it uses a blacklist instead of a whitelist,
so
> > you should be good without needing changes to that script.
> 
> Thanks John - I was thinking that we probably just want this package to be in
> pub, but not to be shipped with the SDK. So maybe I won't need to add it to
> create_sdk either. Similar to how today we push the 'browser' package.

Then this will work just fine :) .

[Jennifer Messerly, 2013-02-05 06:13:22]

On 2013/02/05 05:35:28, dgrove wrote:
> On 2013/02/05 05:34:25, Siggi Cherem (dart-lang) wrote:
> > On 2013/02/05 05:22:08, John Messerly wrote:
> > > On 2013/02/05 05:12:59, Siggi Cherem (dart-lang) wrote:
> > > > This CL is a simple code move: the same code was reviewed before in our
> > > external
> > > > repo (here: https://github.com/dart-lang/source-maps/)
> > > > 
> > > > The only thing that changed (besides the obvious move) is that the
pubspec
> > no
> > > > longer has a version number, so it can be assigned automatically when we
> > > upload
> > > > it from trunk.
> > > > 
> > > > Dan/Bob - are there any other requirements to make this a pkg package?
> Will
> > > this
> > > > be published in pub by the upload script on the next release or do we
need
> > to
> > > > add this to some list somewhere?
> > > > 
> > > > Peter - I hope this will be helpful for you =). Please coordinate with
me
> if
> > > > you'd like to make improvements. The API with spans and locations is
> > actually
> > > > quite important as this will be used by several of our other tools
> > (html5lib,
> > > > web-ui, etc).
> > > 
> > > The only one I know is
> > >     tools/create_sdk.py
> > > 
> > > It's used for package import rewriting magic. Search in there for "yaml",
> > > there's a list you need to have your package be in. Dan also has
> > > tools/publish_all_pkgs.py, but it uses a blacklist instead of a whitelist,
> so
> > > you should be good without needing changes to that script.
> > 
> > Thanks John - I was thinking that we probably just want this package to be
in
> > pub, but not to be shipped with the SDK. So maybe I won't need to add it to
> > create_sdk either. Similar to how today we push the 'browser' package.
> 
> Then this will work just fine :) .

*confused*. I thought the whole point of moving it into the Dart SVN repo was so
that other code, which is part of the SDK, can refer to it.

The reason to fix create_sdk is so other things in SDK can have their package:
URL resolved correctly.

[Jennifer Messerly, 2013-02-05 06:14:26]

Here's a concrete example. Yaml is a package. Pub needs to import Yaml. So I had
to fix create_sdk and add "yaml". Without fixing that, Pub was broken.

[Siggi Cherem (dart-lang), 2013-02-05 18:17:46]

On 2013/02/05 06:14:26, John Messerly wrote:
> Here's a concrete example. Yaml is a package. Pub needs to import Yaml. So I
had
> to fix create_sdk and add "yaml". Without fixing that, Pub was broken.

Ah, I see your point, that's a good question. I guess I'm not clear yet what is
the use this will be given within the Dart SVN Repo. Maybe Peter can clarify a
bit here.

Peter - is the intention to use it internally for testing? or will this be used
directly from dart2js or another piece of the sdk?

[Siggi Cherem (dart-lang), 2013-02-06 01:41:13]

On 2013/02/05 18:17:46, Siggi Cherem (dart-lang) wrote:
> On 2013/02/05 06:14:26, John Messerly wrote:
> > Here's a concrete example. Yaml is a package. Pub needs to import Yaml. So I
> had
> > to fix create_sdk and add "yaml". Without fixing that, Pub was broken.
> 
> Ah, I see your point, that's a good question. I guess I'm not clear yet what
is
> the use this will be given within the Dart SVN Repo. Maybe Peter can clarify a
> bit here.
> 
> Peter - is the intention to use it internally for testing? or will this be
used
> directly from dart2js or another piece of the sdk?

Based on our discussion earlier today, I'm inclined to submit it as it is and
add it to the sdk when we start depending on it from another package. Thought?

[Jennifer Messerly, 2013-02-06 01:43:18]

On 2013/02/06 01:41:13, Siggi Cherem (dart-lang) wrote:
> On 2013/02/05 18:17:46, Siggi Cherem (dart-lang) wrote:
> > On 2013/02/05 06:14:26, John Messerly wrote:
> > > Here's a concrete example. Yaml is a package. Pub needs to import Yaml. So
I
> > had
> > > to fix create_sdk and add "yaml". Without fixing that, Pub was broken.
> > 
> > Ah, I see your point, that's a good question. I guess I'm not clear yet what
> is
> > the use this will be given within the Dart SVN Repo. Maybe Peter can clarify
a
> > bit here.
> > 
> > Peter - is the intention to use it internally for testing? or will this be
> used
> > directly from dart2js or another piece of the sdk?
> 
> Based on our discussion earlier today, I'm inclined to submit it as it is and
> add it to the sdk when we start depending on it from another package. Thought?

Dunno, unless we're sure something in the SDK will use it, seems premature to
move the source code. Up to you though.

[Jennifer Messerly, 2013-02-06 02:01:27]

fwiw, this CL LGTM for checkin.

[Siggi Cherem (dart-lang), 2013-02-06 02:05:06]

On 2013/02/06 02:01:27, John Messerly wrote:
> fwiw, this CL LGTM for checkin.

Thanks John - I'll wait for Peter's feedback and see what's the use case for
this, whether it is needed for the SDK or if it's just needed as an utility. If
it's not for the SDK, we can talk about what we prefer to do.

[ahe, 2013-03-20 11:04:45]

Sorry, I didn't realize that you were waiting for my input.

This is definitely something we need in the SDK.  First for testing.  In the
future, perhaps a tool that can parse a source map and a stack trace and
translate the stack trace.

[Siggi Cherem (dart-lang), 2013-03-20 23:04:16]

On 2013/03/20 11:04:45, ahe wrote:
> Sorry, I didn't realize that you were waiting for my input.
> 
> This is definitely something we need in the SDK.  First for testing.  In the
> future, perhaps a tool that can parse a source map and a stack trace and
> translate the stack trace.

Thanks Peter - I also had in mind to remind you, but we've been busy with many
other things.

Ok, I'll go ahead and move it. I have to update this CL with the latest version
of our source maps code first...

[Jennifer Messerly, 2013-03-20 23:29:21]

SGTM. Thanks guys!

[Siggi Cherem (dart-lang), 2013-03-20 23:41:00]

ok - I just updated to the latest sources. Submitting.

[Siggi Cherem (dart-lang), 2013-03-20 23:41:59]

Committed patchset #4 manually as r20300 (presubmit successful).