Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1220633003: Try incremental analysis before limiting invalidation. (Closed)

Created:
5 years, 5 months ago by scheglov
Modified:
5 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Try incremental analysis before limiting invalidation. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/8dc75028846459750de08f4c9067181422d4d2a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -22 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 3 chunks +24 lines, -16 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 3 chunks +32 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 5 months ago (2015-06-29 16:56:57 UTC) #1
Brian Wilkerson
LGTM
5 years, 5 months ago (2015-06-29 17:00:16 UTC) #2
scheglov
5 years, 5 months ago (2015-06-29 17:00:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8dc75028846459750de08f4c9067181422d4d2a6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698