Issue 1220553002: Ignore the DART_SDK variable in pub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1220553002: Ignore the DART_SDK variable in pub. (Closed)

Created:
5 years, 6 months ago by nweiz

Modified:
5 years, 5 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/pub.git@master

Target Ref:
refs/heads/stable

Visibility:
Public.

More Reviews

Description

Ignore the DART_SDK variable in pub. Now that Platform.resolvedExecutable exists, the environment variable only provided a way to load files from the wrong SDK. Closes #1288 R=rnystrom@google.com

Patch Set 1 #

Patch Set 2 : change target branch #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	lib/src/sdk.dart	View		1 chunk	+1 line, -4 lines	0 comments	Download
	M	pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

5 years, 5 months ago (2015-06-29 19:18:01 UTC) #3

Committed patchset #1 (id:1) manually as
d6855962e0221f0ca3b2756877803916bafd296c (presubmit successful).

Expand Messages | Collapse Messages