Issue 1220333003: dart2js: Rename emitters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1220333003: dart2js: Rename emitters. (Closed)

Created:
5 years, 5 months ago by floitsch

Modified:
5 years, 5 months ago

Reviewers:
herhut

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

dart2js: Rename emitters. The "old" and "new" name was not helpful. R=herhut@google.com Committed: https://github.com/dart-lang/sdk/commit/908865c47e729519fc51dbe56a5ec0531b98cfdb

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -5785 lines)			Patch
M	pkg/compiler/lib/src/js/js.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/backend.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/js_backend/js_backend.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/code_emitter_task.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	pkg/compiler/lib/src/js_emitter/full_emitter/class_builder.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	pkg/compiler/lib/src/js_emitter/full_emitter/code_emitter_helper.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	pkg/compiler/lib/src/js_emitter/full_emitter/declarations.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	pkg/compiler/lib/src/js_emitter/full_emitter/interceptor_emitter.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/js_emitter.dart	View	2 chunks	+10 lines, -10 lines	0 comments	Download
A +	pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart	View	1 chunk	+0 lines, -184 lines	0 comments	Download
D	pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart	View	1 chunk	+0 lines, -1247 lines	0 comments	Download
D	pkg/compiler/lib/src/js_emitter/old_emitter/class_builder.dart	View	1 chunk	+0 lines, -91 lines	0 comments	Download
D	pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart	View	1 chunk	+0 lines, -576 lines	0 comments	Download
D	pkg/compiler/lib/src/js_emitter/old_emitter/code_emitter_helper.dart	View	1 chunk	+0 lines, -23 lines	0 comments	Download
D	pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart	View	1 chunk	+0 lines, -181 lines	0 comments	Download
D	pkg/compiler/lib/src/js_emitter/old_emitter/declarations.dart	View	1 chunk	+0 lines, -90 lines	0 comments	Download
D	pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart	View	1 chunk	+0 lines, -2017 lines	0 comments	Download
D	pkg/compiler/lib/src/js_emitter/old_emitter/interceptor_emitter.dart	View	1 chunk	+0 lines, -103 lines	0 comments	Download
D	pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart	View	1 chunk	+0 lines, -391 lines	0 comments	Download
D	pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart	View	1 chunk	+0 lines, -855 lines	0 comments	Download
M	pkg/compiler/lib/src/patch_parser.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/js_runtime/lib/annotations.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/js_runtime/lib/core_patch.dart	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/compiler/dart2js/mock_libraries.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/patch_test.dart	View	2 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

floitsch

5 years, 5 months ago (2015-07-07 12:47:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
908865c47e729519fc51dbe56a5ec0531b98cfdb (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages