Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 1220233004: Fix comparison of StreamIterator with Iterable - should be Iterator. (Closed)

Created:
5 years, 5 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 5 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix comparison of StreamIterator with Iterable - should be Iterator. R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/e0a61ceeb4777e236a8e0239d315b368aa09562b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sdk/lib/async/stream.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Lasse Reichstein Nielsen
5 years, 5 months ago (2015-07-03 11:26:15 UTC) #2
Søren Gjesse
lgtm
5 years, 5 months ago (2015-07-03 11:27:01 UTC) #3
Lasse Reichstein Nielsen
5 years, 5 months ago (2015-07-03 11:30:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e0a61ceeb4777e236a8e0239d315b368aa09562b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698