Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 1220233003: dart2js: Give the globals holder for deferred loading a fixed name. (Closed)

Created:
5 years, 5 months ago by herhut
Modified:
5 years, 5 months ago
Reviewers:
floitsch, sigurdm
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Give the globals holder for deferred loading a fixed name. R=floitsch@google.com, sigurdm@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/5c4749ac92fbeed58c06112a56860df36a0a4b01

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
herhut
The globalsHolder is not a global name in the sense of the namer. It is ...
5 years, 5 months ago (2015-07-03 08:40:14 UTC) #1
herhut
On 2015/07/03 08:40:14, herhut wrote: > The globalsHolder is not a global name in the ...
5 years, 5 months ago (2015-07-03 08:45:23 UTC) #3
floitsch
LGTM.
5 years, 5 months ago (2015-07-03 10:26:21 UTC) #4
herhut
Committed patchset #1 (id:1) manually as 5c4749ac92fbeed58c06112a56860df36a0a4b01 (presubmit successful).
5 years, 5 months ago (2015-07-03 10:46:59 UTC) #5
sigurdm
5 years, 5 months ago (2015-07-08 06:58:11 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698