dart2js cps: Ensure definitions are specialized before their uses.

dart2js cps: Ensure definitions are specialized before their uses.

Specializing a node may depend on how its operands are defined, but
they may no longer depend on how its result is used.

Patterns that depended on its result being converted to a boolean
violated this rule, but fortunately they could be refactored to
satisfy the rule, by matching the node doing doing the boolean
conversion.

By processing definitions before their uses, we avoid creating new
redexes for a node that has already been processed.


BUG=
R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/fb8c42cbdbfb431d3b22394582b8379b05499583

[asgerf, 2015-07-06 17:32:39]

asgerf@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2015-07-06 18:18:36]

Haven't finished yet.
Will continue tomorrow.

https://codereview.chromium.org/1220123004/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart (right):

https://codereview.chromium.org/1220123004/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart:197: /// Concretely, this is try
when [enterTry] has been called without
-try-

https://codereview.chromium.org/1220123004/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart:251: isEscapingTry:
isEscapingTry);
indent +2

https://codereview.chromium.org/1220123004/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart (right):

https://codereview.chromium.org/1220123004/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart:572: // Notably, such an
invocation cannot be inlined.
The name and the description don't seem to match.

https://codereview.chromium.org/1220123004/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart:573: bool isEscapingTry;
can this be final?

[asgerf, 2015-07-07 08:42:05]

https://codereview.chromium.org/1220123004/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart (right):

https://codereview.chromium.org/1220123004/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart:197: /// Concretely, this is try
when [enterTry] has been called without
On 2015/07/06 18:18:35, floitsch wrote:
> -try-

-> true :)

https://codereview.chromium.org/1220123004/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart:251: isEscapingTry:
isEscapingTry);
On 2015/07/06 18:18:35, floitsch wrote:
> indent +2

Done.

https://codereview.chromium.org/1220123004/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart (right):

https://codereview.chromium.org/1220123004/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart:572: // Notably, such an
invocation cannot be inlined.
On 2015/07/06 18:18:35, floitsch wrote:
> The name and the description don't seem to match.

Clarified that LetHandlers are try blocks.

https://codereview.chromium.org/1220123004/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart:573: bool isEscapingTry;
On 2015/07/06 18:18:36, floitsch wrote:
> can this be final?

So far yes.

[floitsch, 2015-07-07 11:11:48]

LGTM.

[asgerf, 2015-07-07 11:28:58]

Committed patchset #3 (id:40001) manually as
fb8c42cbdbfb431d3b22394582b8379b05499583 (presubmit successful).