Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1219833003: Fix build directory cleaner, to not follow links on Windows. (Closed)

Created:
5 years, 5 months ago by Bill Hesse
Modified:
5 years, 5 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix build directory cleaner, to not follow links on Windows. BUG= R=ricow@google.com Committed: https://github.com/dart-lang/sdk/commit/120bff1f3bdf347351c6903dc3df0cd51f1837c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M tools/clean_output_directory.py View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Bill Hesse
5 years, 5 months ago (2015-06-30 11:50:43 UTC) #2
ricow1
lgtm
5 years, 5 months ago (2015-06-30 12:05:42 UTC) #3
Bill Hesse
5 years, 5 months ago (2015-06-30 12:08:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
120bff1f3bdf347351c6903dc3df0cd51f1837c6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698